use-subscription tearing fix #16623
use-subscription tearing fix #16623
Conversation
| jest.runAllTimers(); | ||
|
|
||
| // Partial update "C" -> "D" | ||
| // Interrupt with a second mutation "D" -> "E" but this should not cause tearing. |
There was a problem hiding this comment.
This second interrupting mutation is required to trigger the previous failure. (Described in more detail in this issue comment.) I don't yet understand why this is but will be digging in more.
There was a problem hiding this comment.
It looks like React eagerly computes the state initially, for the first update. It doesn't do this or subsequent updates though because expirationTime !== NoWork.
I'm not sure if this is expected, given that my test flushes all pending work.
There was a problem hiding this comment.
@acdlite and I chatted about this offline and I have a better understanding of it now. I've updated the inline test comments. Going to hand this PR to him since he has full context now too.
Details of bundled changes.Comparing: f962feb...5ba5309 use-subscription
|
|
Ping @acdlite :) |
Adds a test (previously failing) and a fix for a potential tearing case reported in #16396.
Resolves #16396