Exclude react-dom when flow checking other builds #16737
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I pulled this commit out of #16725 into a separate PR.
Any given build cannot be self-consistent if we type check all the files that are part of other builds. That's because the HostConfig is swapped out.
Imagine for example a shared method that accepts an
Instance
type:And a file specific to ReactDOM might reference this:
But when we check the native file this won't work.
This is because the HostConfig can't be guaranteed to be consistent with other code such as code that touches the DOM directly.
Ideally we'd have a more systemic solution to this since it will pop up for other packages later too.