[Scheduler] Prevent event log from growing unbounded #16781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a Scheduler profile runs without stopping, the event log will grow unbounded. Eventually it will run out of memory and the VM will throw an error. To prevent this from happening, let's automatically stop the profiler once the log exceeds a certain limit. We'll also print a warning with advice to call `stopLoggingProfilingEvents` explicitly.
acdlite
commented
Sep 13, 2019
| ); | ||
| eventLogSize *= 2; | ||
| if (eventLogSize > MAX_EVENT_LOG_SIZE) { | ||
| console.error( |
There was a problem hiding this comment.
This message will increase the size of the profiling build. Seems fine? Idk.
acdlite
commented
Sep 13, 2019
| : MAX_TEST_ITERATIONS; | ||
| const maxIterations = t.logicalExpression( | ||
| '||', | ||
| t.memberExpression( |
There was a problem hiding this comment.
@gaearon Might want to review the changes I made in here. I wanted to increase the limit for a specific test so I could trigger the memory error.
acdlite
force-pushed
the
scheduler-profiler-memory
branch
2 times, most recently
from
8fe678d to
1f55c5a
Compare
Details of bundled changes.Comparing: 87eaa90...1f55c5a react
scheduler
|
sebmarkbage
approved these changes
Sep 13, 2019
|
Ok I'm going to land as-is though because I don't have any better ideas for how to test it right now, and I'd rather have a slow test than no test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a Scheduler profile runs without stopping, the event log will grow unbounded. Eventually it will run out of memory and the VM will throw an error.
To prevent this from happening, let's automatically stop the profiler once the log exceeds a certain limit. We'll also print a warning with advice to call
stopLoggingProfilingEventsexplicitly.