Stop warning about setNativeProps being deprecated #17045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundled changes.Comparing: b71ab61...9ce90ae react-native-renderer
|
rickhanlonii
pushed a commit
to rickhanlonii/react
that referenced
this pull request
Oct 9, 2019
* Stop warning about setNativeProps being deprecated * Remove ReactNative.setNativeProps * Remove more Fabric tests
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Oct 9, 2019
Summary: This diff is a partial sync of React into React Native. ## Source The source branch is from my fork [here](https://github.com/facebook/react/compare/master...rickhanlonii:react-native-partial-sync-october-9?expand=1) This branch is created from D17456249 which partially synced Dan's branch [here](facebook/react@master...gaearon:partsync). To create my branch, I forked from Dan's branch and added two commits from these PRs: - Joshua's PR to improve view config errors facebook/react#16879 - Eli's PR to remove setNativeProps warning facebook/react#17045 Reviewed By: gaearon Differential Revision: D17828989 fbshipit-source-id: 75c99737f2dec4889d7d453bbdebaeb47656b5ce
youmoxiyou
pushed a commit
to youmoxiyou/react-native
that referenced
this pull request
Oct 10, 2019
Summary: This diff is a partial sync of React into React Native. ## Source The source branch is from my fork [here](https://github.com/facebook/react/compare/master...rickhanlonii:react-native-partial-sync-october-9?expand=1) This branch is created from D17456249 which partially synced Dan's branch [here](facebook/react@master...gaearon:partsync). To create my branch, I forked from Dan's branch and added two commits from these PRs: - Joshua's PR to improve view config errors facebook/react#16879 - Eli's PR to remove setNativeProps warning facebook/react#17045 Reviewed By: gaearon Differential Revision: D17828989 fbshipit-source-id: 75c99737f2dec4889d7d453bbdebaeb47656b5ce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added this code in #14907 and #14912.
This warning was was enabled with a feature flag only at Facebook. We had all these warnings ignored and figured we'd migrate to the new API as part of Fabric.
This actually makes little sense. Importing setNativeProps from 'react-native' won't give us the Fabric version of
setNativeProps. The only way to do that is by calling it on aref. Even with that, we don't know if setNativeProps will exist in fabric, so migrating to a new API just to stop supporting it doesn't make sense. We added a warning and made the implementation in Fabric a no-op here: #15094All things considered, this change isn't necessary today, adds some bloat, is not used anywhere (it's not even exported by React Native's public API in the current release) and just triggers a ton of warnings for us at Facebook.
Also, none of our other APIs that we are migrating from for Fabric currently show warnings. It doesn't make much sense to have this one warn but none of the others.
Let's remove and revisit if we want some form of this in the future.