HostText needs to copy over from current if it is unchanged #17538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tent mode stateNode is not one of the fields that gets copied over by createWorkInProgress. This is bad for persistent mode since it's not the same instance. In HostComponent we happened to always end up transferring the current stateNode when we bail. However, we didn't do this for HostText.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 21747e9:
|
|
Thanks for fixing this so quickly! |
gaearon
approved these changes
Dec 6, 2019
|
@sebmarkbage Is there a plan to add tests to this and land / is anyone driving it? This will become/is a blocker for Fabric TextInput. |
|
@JoshuaGross I was planning to do a sync after the holidays. This is currently blocked by lack of tests but we can land by then if @sebmarkbage doesn't write any. |
|
@gaearon Looks like we should just merge this in, since there haven't been any updates / tests |
|
I got it in. I will run a sync once I’m back from PTO — on Monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stateNode is not one of the fields that gets copied over by createWorkInProgress.
This is bad for persistent mode since it's not the same instance.
In HostComponent we happened to always end up transferring the current stateNode when we bail.
However, we didn't do this for HostText.
Found by @JoshuaGross in Fabric.
TODO: Unit tests.