Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grammar fix #17825

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Grammar fix #17825

merged 1 commit into from
Feb 10, 2020

Conversation

haseebdaone
Copy link
Contributor

Just going through the source to get a better understanding of React and saw a grammar mistake.

replaced 'add' with 'subtract'

Update ReactFiberExpirationTime.js
dc5ae7b 
replaced 'add' with 'subtract'
@haseebdaone haseebdaone changed the title Update ReactFiberExpirationTime.js Grammar fix Jan 12, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dc5ae7b:

Sandbox Source
lucid-lamport-94ncn Configuration

@sizebot
Copy link

sizebot commented Jan 12, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against dc5ae7b

@sizebot
Copy link

sizebot commented Jan 12, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against dc5ae7b

@trueadm
Copy link
Contributor

trueadm commented Feb 10, 2020

Thanks!

@trueadm trueadm merged commit b63cb6f into facebook:master Feb 10, 2020
gaearon added a commit that referenced this pull request Feb 10, 2020
@gaearon
Revert "Update ReactFiberExpirationTime.js (#17825)"
1ce9691 
This reverts commit b63cb6f.
@gaearon gaearon mentioned this pull request Feb 10, 2020
Merged
@gaearon
Copy link
Collaborator

gaearon commented Feb 10, 2020

This is not a grammar fix, it is a semantic change to what the comment was saying.

gaearon added a commit that referenced this pull request Feb 10, 2020
@gaearon
Tweak comment wording (#18007)
517de74 
* Revert "Update ReactFiberExpirationTime.js (#17825)"

This reverts commit b63cb6f.

* Reword
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tayyab-razzaq tayyab-razzaq tayyab-razzaq approved these changes

@mam1konyan mam1konyan mam1konyan approved these changes

@devTomek devTomek devTomek approved these changes

@jameskip jameskip jameskip approved these changes

@Hovakimyan Hovakimyan Hovakimyan approved these changes

@bsdahl bsdahl bsdahl approved these changes

@sleepwalkerfx sleepwalkerfx sleepwalkerfx approved these changes

@trueadm trueadm trueadm approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.