Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove root.unmount() callback from DevTools code #17939

Merged
merged 1 commit into from
Jan 30, 2020

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Jan 30, 2020

Updating DevTools in response to #17916

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 30, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit aaf258c:

Sandbox Source
busy-shockley-os6p9 Configuration

@sizebot
Copy link

sizebot commented Jan 30, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against aaf258c

@sizebot
Copy link

sizebot commented Jan 30, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against aaf258c

@bvaughn bvaughn merged commit d2ae77d into facebook:master Jan 30, 2020
@bvaughn bvaughn deleted the devtools-remove-unmount-callback branch January 30, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants