Refactor DOM plugin system to fewer modules #18025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trueadm
requested review from
threepointone,
bvaughn,
sebmarkbage,
philipp-spiess,
gaearon,
acdlite and
aweary
trueadm
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 98f306c:
|
trueadm
force-pushed
the
move-dom-plugin-logic-to-own-module
branch
from
86d7203
to
0de3d8f
Compare
trueadm
commented
Feb 12, 2020
trueadm
commented
Feb 12, 2020
| return null; | ||
| } | ||
| listener = props[registrationName]; | ||
| if (shouldPreventMouseEvent(registrationName, inst.type, props)) { |
There was a problem hiding this comment.
It's a shame that this runs for Fabric and RN too. This is definitely something we should remove once we get to clean up the existing DOM event system.
trueadm
commented
Feb 12, 2020
| @@ -282,7 +282,7 @@ to return true:wantsResponderID| | | |||
| + + */ | |||
|
|
|||
| /** | |||
| * A note about event ordering in the `EventPluginHub`. | |||
| * A note about event ordering in the `EventPluginRegistry`. | |||
There was a problem hiding this comment.
We inject into the EventPluginRegistry now, so the comment changes are to reflect that.
This comment has been minimized.
This comment has been minimized.
Clean up comments fix
trueadm
force-pushed
the
move-dom-plugin-logic-to-own-module
branch
from
0de3d8f
to
98f306c
Compare
Details of bundled changes.Comparing: a607ea4...98f306c react-native-renderer
react-dom
ReactDOM: size: -0.1%, gzip: -0.2% Size changes (stable) |
gaearon
approved these changes
Feb 14, 2020
aweary
approved these changes
Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors and cleans up the existing logic around React's DOM event plugin system. This is primiary to make the system somewhat easier to fork and manage as part of the future work and investigation into possibly using React Roots as the delegation nodes rather than using only the
document. Please note, there should be no logic/functionaly changes from this PR, and all existing code paths should still work.Notably, this PR does the following:
DOMEventPluginSystem, this is where the bulk of the DOM plugin event system sits. This file should be forkable for future work with relative ease.EventPluginHubhas been removed. Instead the core functions have now moved to their respective renderers instead. This should make it easier to make changes to the DOM event system in the future without impacting other renderers that keep the existing plugin system.getListenerhas been added. This function was previously inEventPluginHub, but now is a single module and exported function, as it is required during the event propagation phase.ReactDOMEventListenerpreviously had a lot of logic relating to the DOM plugin system. This has now been moved intoDOMEventPluginSystem.EventPluginHub-testthat was more a test for invalid listeners, so the test has changed name to reflect this better.EventPluginRegistryrather than theEventPluginHub.ReactDOMClientInjection. In future React versions, we might want to remove this module and instead inline the event plugins directly into the event system instead to save bytes and improve runtime performance (RNW currently requires this as of React 16).