Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[www] Disable Scheduler timeout w/ dynamic flag #18069

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Feb 18, 2020

Before attempting to land an expiration times refactor, I want to see if this particular change will impact performance (either positively or negatively). I will test this with a GK.

Before attempting to land an expiration times refactor, I want to see
if this particular change will impact performance (either positively
or negatively). I will test this with a GK.
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 18, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 722f5eb:

Sandbox Source
holy-wave-k11g0 Configuration

@sizebot
Copy link

sizebot commented Feb 18, 2020

Details of bundled changes.

Comparing: 1a6d817...722f5eb

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.88 KB 3.88 KB 1.55 KB 1.55 KB UMD_DEV
ReactDOM-dev.js 0.0% 0.0% 988.93 KB 988.99 KB 218.03 KB 218.03 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% -0.0% 55.46 KB 55.46 KB 15.61 KB 15.61 KB UMD_DEV
react-dom-testing.profiling.min.js 0.0% 0.0% 121.27 KB 121.27 KB 38.25 KB 38.25 KB NODE_PROFILING
react-dom-test-utils.production.min.js 0.0% -0.0% 11.21 KB 11.21 KB 4.17 KB 4.17 KB UMD_PROD
react-dom-server.browser.production.min.js 0.0% -0.0% 20.46 KB 20.46 KB 7.5 KB 7.5 KB UMD_PROD
react-dom-test-utils.development.js 0.0% -0.0% 53.73 KB 53.73 KB 15.29 KB 15.29 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% -0.1% 10.99 KB 10.99 KB 4.1 KB 4.1 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 58.73 KB 58.73 KB 15.36 KB 15.36 KB UMD_DEV
ReactTestUtils-dev.js +0.2% +0.2% 52.65 KB 52.76 KB 14.33 KB 14.36 KB FB_WWW_DEV
ReactDOMServer-dev.js +0.1% +0.1% 140.25 KB 140.37 KB 35.5 KB 35.53 KB FB_WWW_DEV
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 58.43 KB 58.43 KB 15.28 KB 15.28 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 119.93 KB 119.93 KB 37.57 KB 37.57 KB NODE_PROD
ReactDOM-prod.js 🔺+0.1% 🔺+0.1% 372.47 KB 372.78 KB 67.68 KB 67.73 KB FB_WWW_PROD
ReactDOM-profiling.js +0.1% +0.1% 383.78 KB 384.08 KB 69.74 KB 69.79 KB FB_WWW_PROFILING
react-dom-testing.development.js 0.0% -0.0% 965.87 KB 965.87 KB 216.51 KB 216.5 KB UMD_DEV
react-dom-testing.profiling.min.js 0.0% -0.0% 121.04 KB 121.04 KB 39 KB 39 KB UMD_PROFILING
react-dom-testing.production.min.js 0.0% 0.0% 117.59 KB 117.59 KB 37.17 KB 37.17 KB NODE_PROD
react-dom-server.node.production.min.js 0.0% -0.0% 20.79 KB 20.79 KB 7.62 KB 7.62 KB NODE_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactART-dev.js 0.0% 0.0% 624.75 KB 624.8 KB 129 KB 129 KB FB_WWW_DEV
react-art.development.js 0.0% -0.0% 612.01 KB 612.01 KB 129.13 KB 129.13 KB NODE_DEV
react-art.production.min.js 0.0% -0.0% 72.5 KB 72.5 KB 21.66 KB 21.66 KB NODE_PROD
ReactART-prod.js 🔺+0.1% 🔺+0.2% 232.54 KB 232.87 KB 39.16 KB 39.23 KB FB_WWW_PROD

Size changes (experimental)

Generated by 🚫 dangerJS against 722f5eb

@sizebot
Copy link

sizebot commented Feb 18, 2020

Details of bundled changes.

Comparing: 1a6d817...722f5eb

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactDOM-profiling.js +0.1% +0.1% 407.44 KB 407.74 KB 74.1 KB 74.15 KB FB_WWW_PROFILING
react-dom-testing.production.min.js 0.0% 0.0% 117.07 KB 117.07 KB 37.03 KB 37.04 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 58.72 KB 58.72 KB 15.35 KB 15.35 KB UMD_DEV
ReactTestUtils-dev.js +0.2% +0.2% 52.65 KB 52.76 KB 14.33 KB 14.35 KB FB_WWW_DEV
react-dom.production.min.js 0.0% -0.0% 115.95 KB 115.95 KB 37.21 KB 37.21 KB UMD_PROD
react-dom.profiling.min.js 0.0% -0.0% 119.48 KB 119.48 KB 38.38 KB 38.38 KB UMD_PROFILING
react-dom.profiling.min.js 0.0% 0.0% 119.66 KB 119.66 KB 37.64 KB 37.64 KB NODE_PROFILING
ReactDOM-dev.js 0.0% 0.0% 989.88 KB 989.93 KB 218.34 KB 218.34 KB FB_WWW_DEV
react-dom-testing.profiling.min.js 0.0% -0.0% 120.51 KB 120.51 KB 38.85 KB 38.85 KB UMD_PROFILING
ReactDOMServer-dev.js +0.1% +0.1% 140.24 KB 140.36 KB 35.5 KB 35.53 KB FB_WWW_DEV
ReactDOM-prod.js 🔺+0.1% 🔺+0.1% 396.11 KB 396.41 KB 72 KB 72.05 KB FB_WWW_PROD
ReactDOMServer-prod.js 0.0% -0.0% 48.98 KB 48.98 KB 11.18 KB 11.18 KB FB_WWW_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 58.42 KB 58.42 KB 15.28 KB 15.28 KB NODE_DEV
react-dom-test-utils.development.js 0.0% -0.0% 55.44 KB 55.44 KB 15.61 KB 15.61 KB UMD_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 9.98 KB 9.98 KB 3.37 KB 3.37 KB NODE_PROD
react-dom-test-utils.development.js 0.0% -0.0% 53.71 KB 53.71 KB 15.29 KB 15.29 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% -0.1% 10.97 KB 10.97 KB 4.09 KB 4.09 KB NODE_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.production.min.js 0.0% -0.0% 69.98 KB 69.98 KB 20.99 KB 20.99 KB NODE_PROD
react-art.production.min.js 0.0% 0.0% 104.98 KB 104.98 KB 31.84 KB 31.84 KB UMD_PROD
ReactART-dev.js 0.0% -0.0% 624.74 KB 624.79 KB 128.99 KB 128.99 KB FB_WWW_DEV
ReactART-prod.js 🔺+0.1% 🔺+0.2% 240.05 KB 240.38 KB 40.39 KB 40.45 KB FB_WWW_PROD

Size changes (stable)

Generated by 🚫 dangerJS against 722f5eb

@acdlite acdlite merged commit 56d8a73 into facebook:master Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants