Add @nolint to FB bundle headers #18126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e24d36f:
|
gaearon
reviewed
Feb 25, 2020
notlint lol
trueadm
force-pushed
the
no-lint-bundles
branch
from
1057f4e
to
e24d36f
Compare
|
What is this for? Does it still run the lint on the bundles in the React repo or just not in FB? We just caught a bug that would’ve gone to production by running lint on the bundles last week. |
|
This is just for the FB linting. (The directive is not respected by eslint — only by arc lint.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's add the @nolint header to the FB/RN bundles so that we don't run FB eslint on the bundles internally.