Remove runtime dependency on prop-types #18127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d241149:
|
Details of bundled changes.Comparing: 739f20b...d241149 react
react-dom
react-native-renderer
react-art
react-test-renderer
react-reconciler
ReactDOM: size: 0.0%, gzip: 0.0% React: size: 0.0%, gzip: 0.0% Size changes (stable) |
Details of bundled changes.Comparing: 739f20b...d241149 react
react-art
react-dom
react-test-renderer
react-native-renderer
react-reconciler
ReactDOM: size: 0.0%, gzip: 🔺+0.1% React: size: 0.0%, gzip: 0.0% Size changes (experimental) |
|
Looks like the tests doesn’t “see” the stack. |
|
Yeah, only for shallow renderer. I think it just needs to play along nicely by setting the current stack function. |
|
k this should fix it |
sebmarkbage
approved these changes
Feb 28, 2020
Why? |
|
@gaearon wouldn't it make more sense to add native ESM to prop-types? I'm happy to do that. |
|
I think that would be good in general but the concern is that the ecosystem is not ready for transitive usage of ESM. We don’t want to make them autodiscoverable yet, but then it’s hard to try them without manually aliasing everything. So we were hoping to make this very scoped. Since we don’t really need either of those deps in a meaningful way. We also wanted to make React itself have zero dependencies anyway. |
|
Node 13.3+ supports it and it’s planned to be backported into node 12 in April, I’m not sure why the ecosystem wouldn’t be ready. “zero dependencies” isn’t honestly reached by inlining dependencies :-/ I’m confused why that’s a valuable. |
|
Zero dependencies is a valuable property for predictability, security, risk of downstream breakages and being able to reason eg about cost. Also makes things easier for our maintainability. It comes with tradeoffs too but if this is the only one left, it doesn’t provide much value to leave it in. Especially since it’s DEV only it doesn’t get duplicated in prod so it doesn’t come with the normal downside of code duplication in the production bundles. Another nice property is that now |
|
FYI it's been reported that this change broke behavior of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to unblock the ESM work. There is no good story for using a CJS dependency so let's just inline this back. I lost the last argument because
console.errornow "sees" the stack again.