Convert the rest of react-dom and react-test-renderer to Named Exports #18145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5c75e3f:
|
Details of bundled changes.Comparing: 60016c4...5c75e3f react-dom
react-test-renderer
ReactDOM: size: -1.2%, gzip: -1.3% Size changes (experimental) |
Details of bundled changes.Comparing: 60016c4...5c75e3f react-dom
react-test-renderer
ReactDOM: size: -0.1%, gzip: 🔺+0.1% Size changes (stable) |
gaearon
reviewed
Feb 27, 2020
gaearon
reviewed
Feb 27, 2020
| let ReactDOM; | ||
| let ReactDOMServer; | ||
| let ReactTestUtils; | ||
| import ReactTestRenderer from 'react-test-renderer/shallow'; |
There was a problem hiding this comment.
Okay this is what confused me. It should say ReactShallowRenderer.
There was a problem hiding this comment.
potato, potato... fixed :)
gaearon
reviewed
Feb 27, 2020
| @@ -856,4 +856,8 @@ function getMaskedContext(contextTypes, unmaskedContext) { | |||
| return context; | |||
| } | |||
|
|
|||
| // This should probably be a default export and a named export. | |||
There was a problem hiding this comment.
I don't understand what this comment is saying. Which one should it be?
There was a problem hiding this comment.
When we expose a proper ES module we can do:
export default ReactShallowRenderer;
export createRenderer;
It's just that if I do that, then Rollup doesn't do the magic thing to only use module.exports =
gaearon
reviewed
Feb 27, 2020
| // TODO: decide on the top-level export form. | ||
| // This is hacky but makes it work with both Rollup and Jest. | ||
| module.exports = ReactShallowRenderer.default || ReactShallowRenderer; | ||
| export {default} from './src/ReactShallowRenderer'; |
There was a problem hiding this comment.
Isn't this gonna break const ShallowRenderer = require('react-test-renderer/shallow')? Is this not a breaking change?
There was a problem hiding this comment.
No, Rollup makes this into module.exports = if you only export a default. (Babel doesn't which is what Jest is struggling with.)
Nothing interesting here except that ReactShallowRenderer currently exports a class with a static method instead of an object. I think the public API is probably just meant to be createRenderer but currently the whole class is exposed. So this means that we have to keep it as default export. We could potentially also expose a named export for createRenderer but that's going to cause compatibility issues. So I'm just going to make that export default. Unfortunately Rollup and Babel (which powers Jest) disagree on how to import this. So to make it work I had to move the jest tests to imports. This doesn't work with module resetting. Some tests weren't doing that anyway and the rest is just testing ReactShallowRenderer so meh.
sebmarkbage
force-pushed
the
namedexportsdom
branch
from
a3d4535
to
5c75e3f
Compare
|
beautiful |
NMinhNguyen
added a commit
to enzymejs/react-shallow-renderer
that referenced
this pull request
Feb 27, 2020
NMinhNguyen
added a commit
to enzymejs/react-shallow-renderer
that referenced
this pull request
Feb 27, 2020
NMinhNguyen
added a commit
to enzymejs/react-shallow-renderer
that referenced
this pull request
Feb 27, 2020
renawolford6
added a commit
to renawolford6/react-shallow-renderer
that referenced
this pull request
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing interesting here except that ReactShallowRenderer currently exports a class with a static method instead of an object.
I think the public API is probably just meant to be createRenderer but currently the whole class is exposed. So this means that we have to keep it as default export. We could potentially also expose a named export for createRenderer but that's going to cause compatibility issues.
So I'm just going to make that export default.
Unfortunately Rollup and Babel (which powers Jest) disagree on how to import this. So to make it work I had to move the jest tests to imports.
This doesn't work with module resetting. Some tests weren't doing that anyway and the rest is just testing ReactShallowRenderer so meh.
Also see #18144