Don't build shallow renderer for FB #18153
Conversation
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 307d296:
|
| @@ -295,7 +295,7 @@ const bundles = [ | |||
| }), | |||
| }, | |||
| { | |||
| bundleTypes: [FB_WWW_DEV, NODE_DEV, NODE_PROD, UMD_DEV, UMD_PROD], | |||
| bundleTypes: [NODE_DEV, NODE_PROD, UMD_DEV, UMD_PROD], | |||
There was a problem hiding this comment.
We really don't need any of these right? This is just building a forwarding file. We can just hard code that in the /npm/ folder instead. https://github.com/facebook/react/blob/master/packages/react-test-renderer/npm/shallow.js
Like we do for other forwarding modules that are just blank. https://github.com/facebook/react/blob/master/packages/react-dom/npm/server.js
There was a problem hiding this comment.
I might be missing something, but I think you'd still need UMD. But otherwise, for Node you should be able to hardcode in /npm/.
We're now getting it from npm (
react-shallow-renderer) so we don't need this bundle.Related diff: D20142456.