Use accumulateTwoPhaseDispatchesSingle directly #18203
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this when working on the modern event system, so thought I'd add the improvement separately.
We only accumulate two phase dispatches on a single event. So passing it to
accumulateTwoPhaseDispatches
is unecessary in a bunch of places and is just overhead and runtime indirection.Furthermore, with the modern event system we may want to add an additonal argument to
accumulateTwoPhaseDispatchesSingle
during event plugin phase, so this makes that far simpler to do.