Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Perf tools #1821

Merged
merged 1 commit into from
Jul 16, 2014
Merged

[Docs] Perf tools #1821

merged 1 commit into from
Jul 16, 2014

Conversation

chenglou
Copy link
Contributor

Fixes #1814.
@petehunt @joshduck
The images look blurry (taken on retina then shrank down to 50%...)

@chenglou
Copy link
Contributor Author

Commit conflicts with #1817. Will rebase when either is merged.

#### `Perf.stop()`
Stops the measurement.

#### `Perf.getLastMeasurements()`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be in an "advanced API" section. Most people won't use this and will be confused.

@chenglou
Copy link
Contributor Author

@petehunt reorganized a bit, highlighted printWasted (didn't put it at the top because printInclusive seemed more introductory). Also put a note on the caveats of profiling dev.

I guess the tutorial/case study should be another post/PR?

@zpao zpao added this to the 0.11 milestone Jul 15, 2014
Fixes facebook#1814.
@petehunt @joshduck
The images look blurry (taken on retina then shrank down to 50%...)
@zpao
Copy link
Member

zpao commented Jul 16, 2014

Ok, no recent comments so merging. We can always make updates later so long as we have something for release.

zpao added a commit that referenced this pull request Jul 16, 2014
@zpao zpao merged commit bb60878 into facebook:master Jul 16, 2014
@chenglou chenglou deleted the docs-addons-perf branch July 16, 2014 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React.addons.Perf documentation
3 participants