Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modern Event System: export internal FB flag for testing #18221

Merged
merged 1 commit into from
Mar 5, 2020

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Mar 5, 2020

This re-exports the enableModernEventSystem flag so we can test this internally at FB.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 5, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 5, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0e4859d:

Sandbox Source
confident-davinci-u4tqf Configuration

@sizebot
Copy link

sizebot commented Mar 5, 2020

Details of bundled changes.

Comparing: 60b11f6...0e4859d

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js 0.0% 0.0% 123.84 KB 123.84 KB 38.64 KB 38.64 KB NODE_PROFILING
ReactDOM-dev.js +0.9% +0.8% 897.53 KB 905.76 KB 200.61 KB 202.13 KB FB_WWW_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% 0.0% 10.27 KB 10.27 KB 3.49 KB 3.5 KB UMD_PROD
ReactDOMServer-dev.js 0.0% 0.0% 137.25 KB 137.31 KB 35.06 KB 35.07 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% -0.0% 53.78 KB 53.78 KB 14.01 KB 14.01 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 10.96 KB 10.96 KB 4.17 KB 4.17 KB UMD_PROD
ReactDOMTesting-prod.js 0.0% -0.0% 368.74 KB 368.74 KB 67.46 KB 67.46 KB FB_WWW_PROD
react-dom-test-utils.development.js 0.0% -0.0% 49.56 KB 49.56 KB 13.52 KB 13.52 KB NODE_DEV
ReactDOMTesting-profiling.js 0.0% -0.0% 368.74 KB 368.74 KB 67.46 KB 67.46 KB FB_WWW_PROFILING
react-dom-server.node.development.js 0.0% -0.0% 131 KB 131 KB 34.81 KB 34.81 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 10.81 KB 10.81 KB 4.1 KB 4.1 KB NODE_PROD
react-dom-server.node.production.min.js 0.0% 0.0% 20.83 KB 20.83 KB 7.61 KB 7.61 KB NODE_PROD
react-dom.development.js 0.0% 0.0% 912.84 KB 912.84 KB 199.76 KB 199.77 KB UMD_DEV
ReactTestUtils-dev.js +0.1% +0.1% 51.31 KB 51.37 KB 13.7 KB 13.72 KB FB_WWW_DEV
react-dom-server.browser.production.min.js 0.0% 0.0% 20.51 KB 20.51 KB 7.51 KB 7.51 KB UMD_PROD
react-dom-server.browser.development.js 0.0% -0.0% 129.78 KB 129.78 KB 34.55 KB 34.55 KB NODE_DEV
ReactDOM-prod.js 🔺+1.5% 🔺+1.2% 370.72 KB 376.26 KB 67.55 KB 68.37 KB FB_WWW_PROD
ReactDOM-profiling.js +1.5% +1.2% 381.98 KB 387.52 KB 69.67 KB 70.48 KB FB_WWW_PROFILING
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.1% 1.19 KB 1.19 KB 698 B 699 B UMD_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.2% 1 KB 1 KB 609 B 610 B NODE_PROD

ReactDOM: size: 0.0%, gzip: 0.0%

Size changes (experimental)

Generated by 🚫 dangerJS against 0e4859d

@sizebot
Copy link

sizebot commented Mar 5, 2020

Details of bundled changes.

Comparing: 60b11f6...0e4859d

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactDOM-profiling.js +1.5% +1.3% 406.37 KB 412.52 KB 74.08 KB 75.04 KB FB_WWW_PROFILING
ReactTestUtils-dev.js +0.1% +0.1% 51.31 KB 51.38 KB 13.7 KB 13.71 KB FB_WWW_DEV
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 55.86 KB 55.86 KB 14.46 KB 14.46 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 116.01 KB 116.01 KB 37.17 KB 37.17 KB UMD_PROD
react-dom.profiling.min.js 0.0% -0.0% 119.54 KB 119.54 KB 38.33 KB 38.33 KB UMD_PROFILING
ReactDOM-dev.js +1.0% +1.1% 939.77 KB 949.32 KB 209.49 KB 211.7 KB FB_WWW_DEV
ReactDOM-prod.js 🔺+1.6% 🔺+1.3% 395.04 KB 401.18 KB 71.91 KB 72.85 KB FB_WWW_PROD
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 3.68 KB 3.68 KB 1.33 KB 1.33 KB NODE_DEV
react-dom-server.browser.development.js 0.0% -0.0% 128.27 KB 128.27 KB 34.33 KB 34.33 KB NODE_DEV
react-dom-test-utils.development.js 0.0% -0.0% 53.77 KB 53.77 KB 14 KB 14 KB UMD_DEV
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.34 KB 3.34 KB 1.26 KB 1.26 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 10.94 KB 10.94 KB 4.16 KB 4.16 KB UMD_PROD
ReactDOMServer-dev.js 0.0% +0.1% 138.1 KB 138.16 KB 35.2 KB 35.22 KB FB_WWW_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 10.79 KB 10.79 KB 4.09 KB 4.09 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 58.9 KB 58.9 KB 14.7 KB 14.7 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.2% 1013 B 1013 B 601 B 602 B NODE_PROD

Size changes (stable)

Generated by 🚫 dangerJS against 0e4859d

@trueadm trueadm merged commit 6a0efdd into facebook:master Mar 5, 2020
@trueadm trueadm deleted the flag-for-modern-system branch March 5, 2020 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants