Break up require/import statements in strings #18222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 49e68a0:
|
Details of bundled changes.Comparing: 6a0efdd...49e68a0 react-test-renderer
react-reconciler
react-dom
react-native-renderer
ReactDOM: size: 0.0%, gzip: 0.0% Size changes (stable) |
gaearon
approved these changes
Mar 5, 2020
Details of bundled changes.Comparing: 6a0efdd...49e68a0 react-dom
react-test-renderer
react-reconciler
react-native-renderer
ReactDOM: size: 0.0%, gzip: 🔺+0.1% Size changes (experimental) |
|
FB: The stack of D20282825 explains the reasons behind this change for FB employees. |
|
A comment definitely, would be extra nice to have a test or lint rule. Otherwise this absolutely will regress. |
sthagen
added a commit
to sthagen/facebook-react
that referenced
this pull request
Mar 6, 2020
Break up require/import statements in strings (facebook#18222)
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Mar 6, 2020
Summary: Similar to the previous diff in this stack, I'm adjusting the React files we use to make sure require and import statements don't get extracted by Jest. Right now Jest extracts them, and when it looks up dependencies in reverse it just ignores the ones that don't exist. Corresponding React PR (to make sure this change doesn't get reverted during the next sync): facebook/react#18222 Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D20282829 fbshipit-source-id: 5ff6a64d31672dd29243d020e8174797a44d9267
osdnk
pushed a commit
to osdnk/react-native
that referenced
this pull request
Mar 9, 2020
Summary: Similar to the previous diff in this stack, I'm adjusting the React files we use to make sure require and import statements don't get extracted by Jest. Right now Jest extracts them, and when it looks up dependencies in reverse it just ignores the ones that don't exist. Corresponding React PR (to make sure this change doesn't get reverted during the next sync): facebook/react#18222 Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D20282829 fbshipit-source-id: 5ff6a64d31672dd29243d020e8174797a44d9267
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We have a number of dependency extractors in JavaScript tools, like Jest but also in internal FB tooling, that are using RegExp to extract static dependencies and create a graph. I am trying to reduce the amount of extractors we have at FB and noticed the Jest one has a few issues that are hard to fix with regex. I realize that RegExp dependency tracking is inherently imprecise but hope we can bear some minor inconvenience in just a few places.
In this PR I'm adjusting the React files we use to make sure require and import statements don't get extracted by Jest. Right now Jest extracts them, and when it looks up dependencies in reverse it just ignores the ones that don't exist. I'd like to make that fail hard in some tools and this change is a pre-requisite for that.
Test Plan
When running this dependencyExtractor from Jest (via jest-haste-map) on react-native, the React files (ReactFabric-dev.fb.js etc.) will no longer have invalid dependencies associated with them.