Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable enableProfilerCommitHooks flag for FB #18230

Merged
merged 1 commit into from
Mar 10, 2020
Merged

Enable enableProfilerCommitHooks flag for FB #18230

merged 1 commit into from
Mar 10, 2020

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Mar 5, 2020

Alternately, I could hook this up to a GK, but it seems like it would be nice if the flag were static.

@bvaughn bvaughn requested a review from sebmarkbage March 5, 2020 19:50
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 5, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 5, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 266d7e1:

Sandbox Source
currying-wave-3nq51 Configuration

@sizebot
Copy link

sizebot commented Mar 5, 2020

Details of bundled changes.

Comparing: 024a764...266d7e1

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js 0.0% -0.0% 124.01 KB 124.01 KB 38.69 KB 38.69 KB NODE_PROFILING
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 58.91 KB 58.91 KB 14.71 KB 14.71 KB UMD_DEV
ReactDOM-dev.js +0.8% +0.5% 906.87 KB 914.41 KB 202.42 KB 203.49 KB FB_WWW_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 10.27 KB 10.27 KB 3.5 KB 3.5 KB UMD_PROD
ReactDOMServer-dev.js 0.0% -0.0% 137.31 KB 137.31 KB 35.08 KB 35.08 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% -0.0% 53.78 KB 53.78 KB 14.01 KB 14.01 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 10.96 KB 10.96 KB 4.17 KB 4.17 KB UMD_PROD
ReactDOMTesting-dev.js 0.0% -0.0% 872.9 KB 872.9 KB 195.5 KB 195.49 KB FB_WWW_DEV
react-dom-server.node.development.js 0.0% -0.0% 131 KB 131 KB 34.81 KB 34.81 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 10.81 KB 10.81 KB 4.1 KB 4.1 KB NODE_PROD
react-dom-server.node.production.min.js 0.0% -0.0% 20.83 KB 20.83 KB 7.61 KB 7.61 KB NODE_PROD
react-dom.development.js 0.0% -0.0% 914.01 KB 914.01 KB 200.07 KB 200.07 KB UMD_DEV
react-dom-server.browser.development.js 0.0% -0.0% 136.78 KB 136.78 KB 34.96 KB 34.96 KB UMD_DEV
react-dom.production.min.js 0.0% -0.0% 119.89 KB 119.89 KB 38.28 KB 38.28 KB UMD_PROD
react-dom-server.browser.production.min.js 0.0% -0.0% 20.51 KB 20.51 KB 7.51 KB 7.51 KB UMD_PROD
react-dom.profiling.min.js 0.0% -0.0% 123.71 KB 123.71 KB 39.54 KB 39.53 KB UMD_PROFILING
react-dom.development.js 0.0% -0.0% 870.01 KB 870.01 KB 197.61 KB 197.61 KB NODE_DEV
react-dom-server.browser.development.js 0.0% -0.0% 129.78 KB 129.78 KB 34.55 KB 34.55 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 120.04 KB 120.04 KB 37.53 KB 37.52 KB NODE_PROD
react-dom-server.browser.production.min.js 0.0% -0.0% 20.43 KB 20.43 KB 7.46 KB 7.46 KB NODE_PROD
ReactDOM-profiling.js +1.4% +1.2% 387.95 KB 393.52 KB 70.54 KB 71.37 KB FB_WWW_PROFILING
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 55.87 KB 55.87 KB 14.47 KB 14.47 KB NODE_DEV
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 3.69 KB 3.69 KB 1.34 KB 1.34 KB NODE_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 10 KB 10 KB 3.38 KB 3.37 KB NODE_PROD
react-dom-unstable-fizz.node.production.min.js 0.0% -0.3% 1.16 KB 1.16 KB 664 B 662 B NODE_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.2% 3.35 KB 3.35 KB 1.27 KB 1.27 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.1% 1.19 KB 1.19 KB 700 B 699 B UMD_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.2% 2.95 KB 2.95 KB 1.18 KB 1.18 KB NODE_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.2% 1 KB 1 KB 611 B 610 B NODE_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js 0.0% -0.0% 635.35 KB 635.35 KB 133.49 KB 133.49 KB UMD_DEV
react-art.production.min.js 0.0% -0.0% 106.64 KB 106.64 KB 32.25 KB 32.25 KB UMD_PROD
react-art.development.js 0.0% -0.0% 539.5 KB 539.5 KB 115.89 KB 115.89 KB NODE_DEV
react-art.production.min.js 0.0% -0.0% 71.62 KB 71.62 KB 21.44 KB 21.44 KB NODE_PROD
ReactART-dev.js +1.4% +1.0% 543.15 KB 550.69 KB 114.02 KB 115.16 KB FB_WWW_DEV

ReactDOM: size: 0.0%, gzip: -0.0%

Size changes (experimental)

Generated by 🚫 dangerJS against 266d7e1

@sizebot
Copy link

sizebot commented Mar 5, 2020

Details of bundled changes.

Comparing: 024a764...266d7e1

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactDOM-profiling.js +1.3% +1.1% 412.95 KB 418.49 KB 75.11 KB 75.91 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% -0.0% 135.19 KB 135.19 KB 34.76 KB 34.75 KB UMD_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% -0.3% 1.15 KB 1.15 KB 655 B 653 B NODE_PROD
react-dom-server.browser.production.min.js 0.0% -0.0% 20.05 KB 20.05 KB 7.42 KB 7.42 KB UMD_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 55.86 KB 55.86 KB 14.46 KB 14.46 KB NODE_DEV
react-dom.development.js 0.0% -0.0% 885.33 KB 885.33 KB 195.14 KB 195.14 KB UMD_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 9.99 KB 9.99 KB 3.37 KB 3.37 KB NODE_PROD
react-dom.production.min.js 0.0% 0.0% 116.01 KB 116.01 KB 37.17 KB 37.18 KB UMD_PROD
react-dom.profiling.min.js 0.0% -0.0% 119.72 KB 119.72 KB 38.39 KB 38.39 KB UMD_PROFILING
react-dom.development.js 0.0% -0.0% 842.51 KB 842.51 KB 192.7 KB 192.7 KB NODE_DEV
react-dom-server.node.development.js 0.0% -0.0% 129.48 KB 129.48 KB 34.59 KB 34.58 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 116.09 KB 116.09 KB 36.5 KB 36.5 KB NODE_PROD
react-dom-server.node.production.min.js 0.0% -0.0% 20.38 KB 20.38 KB 7.53 KB 7.53 KB NODE_PROD
react-dom.profiling.min.js 0.0% -0.0% 119.95 KB 119.95 KB 37.63 KB 37.63 KB NODE_PROFILING
ReactDOM-dev.js +0.8% +0.5% 950.44 KB 957.97 KB 212.01 KB 213.07 KB FB_WWW_DEV
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 3.68 KB 3.68 KB 1.33 KB 1.33 KB NODE_DEV
ReactDOMTesting-dev.js 0.0% -0.0% 899.54 KB 899.54 KB 201.04 KB 201.04 KB FB_WWW_DEV
react-dom-server.browser.development.js 0.0% -0.0% 128.27 KB 128.27 KB 34.33 KB 34.33 KB NODE_DEV
react-dom-test-utils.development.js 0.0% -0.0% 53.77 KB 53.77 KB 14 KB 14 KB UMD_DEV
react-dom-server.browser.production.min.js 0.0% -0.0% 19.97 KB 19.97 KB 7.38 KB 7.38 KB NODE_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.2% 3.34 KB 3.34 KB 1.26 KB 1.26 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 10.94 KB 10.94 KB 4.16 KB 4.16 KB UMD_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.3% 1.17 KB 1.17 KB 692 B 690 B UMD_PROD
ReactDOMServer-dev.js 0.0% -0.0% 138.16 KB 138.16 KB 35.22 KB 35.22 KB FB_WWW_DEV
ReactDOMServer-prod.js 0.0% -0.0% 47.49 KB 47.49 KB 11.05 KB 11.05 KB FB_WWW_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.3% 2.94 KB 2.94 KB 1.17 KB 1.17 KB NODE_DEV
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 58.9 KB 58.9 KB 14.7 KB 14.7 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.2% 1013 B 1013 B 603 B 602 B NODE_PROD
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 10.26 KB 10.26 KB 3.49 KB 3.49 KB UMD_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactART-dev.js +1.3% +1.0% 568.87 KB 576.4 KB 119.3 KB 120.44 KB FB_WWW_DEV
ReactART-prod.js 0.0% 0.0% 233.84 KB 233.84 KB 39.73 KB 39.74 KB FB_WWW_PROD
react-art.development.js 0.0% -0.0% 616.17 KB 616.17 KB 130.09 KB 130.09 KB UMD_DEV
react-art.production.min.js 0.0% -0.0% 104.21 KB 104.21 KB 31.61 KB 31.61 KB UMD_PROD
react-art.development.js 0.0% -0.0% 521.07 KB 521.07 KB 112.45 KB 112.45 KB NODE_DEV
react-art.production.min.js 0.0% -0.0% 69.25 KB 69.25 KB 20.79 KB 20.79 KB NODE_PROD

ReactDOM: size: 0.0%, gzip: -0.0%

Size changes (stable)

Generated by 🚫 dangerJS against 266d7e1

threepointone
threepointone approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦶

@bvaughn bvaughn merged commit 526c12f into facebook:master Mar 10, 2020
@bvaughn bvaughn deleted the profiler-commit-hooks-fb-feature-flag branch March 10, 2020 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@threepointone threepointone threepointone approved these changes

@sebmarkbage sebmarkbage Awaiting requested review from sebmarkbage

@gaearon gaearon Awaiting requested review from gaearon

@trueadm trueadm Awaiting requested review from trueadm

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bvaughn @sizebot @threepointone @facebook-github-bot