Don't fire the render phase update warning for class lifecycles #18330
+127
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This warning is more generic and may happen with class components too.
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 933157f:
|
bvaughn
approved these changes
Mar 17, 2020
acdlite
pushed a commit
to acdlite/react
that referenced
this pull request
Mar 19, 2020
…book#18330) * Change the warning to not say "function body" This warning is more generic and may happen with class components too. * Dedupe by the rendering component * Don't warn outside of render
acdlite
pushed a commit
to acdlite/react
that referenced
this pull request
Mar 19, 2020
…book#18330) * Change the warning to not say "function body" This warning is more generic and may happen with class components too. * Dedupe by the rendering component * Don't warn outside of render
acdlite
pushed a commit
to acdlite/react
that referenced
this pull request
Mar 19, 2020
…book#18330) * Change the warning to not say "function body" This warning is more generic and may happen with class components too. * Dedupe by the rendering component * Don't warn outside of render
acdlite
reviewed
Mar 19, 2020
| @@ -1372,6 +1373,7 @@ function mountIndeterminateComponent( | |||
| context, | |||
| renderExpirationTime, | |||
| ); | |||
| setIsRendering(false); | |||
There was a problem hiding this comment.
If the component throws, setIsRendering won't be reset. This needs to be reset in the the work loop. Here:
react/packages/react-reconciler/src/ReactFiberWorkLoop.js
Lines 1226 to 1229 in 8311cb5
There was a problem hiding this comment.
Never mind, gets reset by resetCurrentDebugFiberInDEV
This was referenced Mar 21, 2020
This was referenced Oct 4, 2024
This was referenced Oct 5, 2024
This was referenced Oct 12, 2024
This was referenced Oct 25, 2024
This was referenced Oct 26, 2024
This was referenced Oct 27, 2024
This was referenced Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18178 (comment).
In 16.13, we added a new warning:
Cannot update a component from inside a body of a function component. But as we see from reports like #18178 (comment), it fired for updates from inside of class lifecycles too. While arguably these are real issues (they happen in render phase) it's pretty noisy for legacy code.In this PR, I do the following:
from inside a body of a function component->while rendering). This more accurately describes when it would fire.renderlifecycles. Everything else will get muted. This is consistent with how our existing class "setState from another component's render" warning works.getDerivedStateFromProps,shouldComponentUpdate, andconstructor. Maybe in strict mode only. However, we should keep them muted forcomponentWill*lifecycles including render phase ones.Here is a table of the changes:
Red means new behavior, blue means revert to 16.12 behavior.