Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inlined DevTools event emitter impl #18378

Merged
merged 3 commits into from
Mar 25, 2020

Commits on Mar 24, 2020

  1. Inlined DevTools event emitter

    DevTools previously used the NPM events package for dispatching events. This package has an unfortunate flaw though- if a listener throws during event dispatch, no subsequent listeners are called. I've replaced that event dispatcher with my own implementation that ensures all listeners are called before it re-throws an error.
    
    This commit replaces that event emitter with a custom implementation that calls all listeners before re-throwing an error.
    Brian Vaughn committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    c28283f View commit details
    Browse the repository at this point in the history
  2. Added some tests for event emitter

    Brian Vaughn committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    cffef3f View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2020

  1. DevTools event emitter: Added more tests

    Clone array before calling listeners in case listeners are added/removed during dispatch.
    Brian Vaughn committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    87076bd View commit details
    Browse the repository at this point in the history