Skip to content

Don't use checkPropTypes for internals #18488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2020
Merged

Don't use checkPropTypes for internals #18488

merged 1 commit into from
Apr 4, 2020

Conversation

@sebmarkbage
Copy link
Collaborator

@sebmarkbage sebmarkbage commented Apr 4, 2020

We use console.error for internal warnings.

@sebmarkbage
Don't use checkPropTypes for internals
0c10b5e 
We use console.error for internal warnings.
@sebmarkbage sebmarkbage requested a review from gaearon April 4, 2020 04:31
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 4, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 4, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0c10b5e:

Sandbox Source
hardcore-ganguly-oh95c Configuration

@sizebot
Copy link

sizebot commented Apr 4, 2020 •
edited
Loading

Details of bundled changes.

Comparing: 5022fdf...8a8f18a

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.production.min.js -0.0% -0.0% 118.76 KB 118.75 KB 37.24 KB 37.23 KB NODE_PROD
react-dom-test-utils.development.js 0.0% -0.0% 61.81 KB 61.81 KB 16.37 KB 16.37 KB UMD_DEV
ReactDOMTesting-profiling.js 0.0% 0.0% 402.69 KB 402.69 KB 72.96 KB 72.96 KB FB_WWW_PROFILING
react-dom-server.browser.production.min.js 0.0% -0.0% 19.46 KB 19.46 KB 7.3 KB 7.3 KB NODE_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 4.81 KB 4.81 KB 1.61 KB 1.61 KB UMD_DEV
react-dom.profiling.min.js -0.0% -0.0% 122.61 KB 122.61 KB 38.39 KB 38.38 KB NODE_PROFILING
react-dom-test-utils.production.min.js 0.0% -0.0% 12.36 KB 12.36 KB 4.57 KB 4.57 KB UMD_PROD
react-dom-server.node.development.js -0.7% -0.5% 128.22 KB 127.37 KB 34.32 KB 34.13 KB NODE_DEV
react-dom-server.node.production.min.js 0.0% -0.0% 19.87 KB 19.87 KB 7.45 KB 7.44 KB NODE_PROD
ReactDOMForked-dev.js -0.1% -0.1% 993.77 KB 992.69 KB 220.5 KB 220.27 KB FB_WWW_DEV
ReactDOMForked-prod.js 0.0% 0.0% 418.31 KB 418.31 KB 75.17 KB 75.18 KB FB_WWW_PROD
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 5.08 KB 5.08 KB 1.67 KB 1.67 KB NODE_DEV
react-dom.development.js -0.1% -0.1% 895.59 KB 894.47 KB 196.62 KB 196.38 KB UMD_DEV
ReactDOMForked-profiling.js 0.0% 0.0% 429.19 KB 429.19 KB 77.02 KB 77.02 KB FB_WWW_PROFILING
react-dom-server.browser.development.js -0.7% -0.5% 133.89 KB 133 KB 34.5 KB 34.32 KB UMD_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% -0.2% 1.16 KB 1.16 KB 658 B 657 B NODE_PROD
react-dom.production.min.js 0.0% 0.0% 118.65 KB 118.65 KB 38 KB 38 KB UMD_PROD
react-dom-server.browser.production.min.js 0.0% -0.0% 19.55 KB 19.55 KB 7.33 KB 7.32 KB UMD_PROD
react-dom.profiling.min.js 0.0% -0.0% 122.37 KB 122.37 KB 39.2 KB 39.18 KB UMD_PROFILING
ReactDOMTesting-dev.js -0.1% -0.1% 946.84 KB 945.76 KB 210.7 KB 210.44 KB FB_WWW_DEV
react-dom.development.js -0.1% -0.1% 852.62 KB 851.55 KB 194.23 KB 193.98 KB NODE_DEV
ReactDOMTesting-prod.js 0.0% 0.0% 402.69 KB 402.69 KB 72.96 KB 72.96 KB FB_WWW_PROD
react-dom-server.browser.development.js -0.7% -0.5% 127 KB 126.16 KB 34.06 KB 33.88 KB NODE_DEV
ReactDOM-dev.js -0.1% -0.1% 993.77 KB 992.69 KB 220.5 KB 220.27 KB FB_WWW_DEV
ReactDOMServer-dev.js -0.6% -0.6% 136.77 KB 135.91 KB 34.86 KB 34.67 KB FB_WWW_DEV
ReactDOM-prod.js 0.0% 0.0% 418.31 KB 418.31 KB 75.17 KB 75.18 KB FB_WWW_PROD
react-dom-test-utils.development.js 0.0% -0.0% 57.18 KB 57.18 KB 15.73 KB 15.73 KB NODE_DEV
ReactDOMServer-prod.js 0.0% -0.0% 46.58 KB 46.58 KB 10.87 KB 10.87 KB FB_WWW_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 4.33 KB 4.33 KB 1.51 KB 1.51 KB NODE_DEV
ReactDOM-profiling.js 0.0% 0.0% 429.19 KB 429.19 KB 77.02 KB 77.02 KB FB_WWW_PROFILING
react-dom-test-utils.production.min.js 0.0% -0.0% 12.22 KB 12.22 KB 4.5 KB 4.49 KB NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.2% 1 KB 1 KB 609 B 608 B NODE_PROD
react-dom-unstable-native-dependencies.production.min.js 0.0% 0.0% 9.98 KB 9.98 KB 3.35 KB 3.36 KB UMD_PROD
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 9.73 KB 9.73 KB 3.25 KB 3.25 KB NODE_PROD

ReactDOM: size: 0.0%, gzip: -0.0%

Size changes (stable)

Generated by 🚫 dangerJS against 8a8f18a

@sizebot
Copy link

sizebot commented Apr 4, 2020 •
edited
Loading

Details of bundled changes.

Comparing: 5022fdf...8a8f18a

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom-server.browser.development.js -0.7% -0.5% 135.47 KB 134.59 KB 34.7 KB 34.52 KB UMD_DEV
react-dom-server.browser.production.min.js 0.0% -0.0% 20.01 KB 20.01 KB 7.41 KB 7.41 KB UMD_PROD
react-dom.profiling.min.js -0.0% -0.0% 126.89 KB 126.88 KB 39.61 KB 39.6 KB NODE_PROFILING
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 4.82 KB 4.82 KB 1.62 KB 1.62 KB UMD_DEV
ReactDOM-dev.js -0.1% -0.1% 965.89 KB 964.81 KB 214.11 KB 213.92 KB FB_WWW_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.1% 1.2 KB 1.2 KB 705 B 704 B UMD_PROD
ReactDOM-prod.js 0.0% -0.0% 405.25 KB 405.25 KB 73.15 KB 73.15 KB FB_WWW_PROD
ReactDOM-profiling.js 0.0% -0.0% 416.06 KB 416.06 KB 74.96 KB 74.95 KB FB_WWW_PROFILING
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 4.35 KB 4.35 KB 1.52 KB 1.52 KB NODE_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.2% 1.02 KB 1.02 KB 617 B 616 B NODE_PROD
react-dom-test-utils.development.js 0.0% -0.0% 61.82 KB 61.82 KB 16.38 KB 16.38 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 12.37 KB 12.37 KB 4.58 KB 4.58 KB UMD_PROD
ReactDOMTesting-dev.js -0.1% -0.1% 920.3 KB 919.21 KB 204.89 KB 204.68 KB FB_WWW_DEV
ReactDOMTesting-prod.js 0.0% -0.0% 390.71 KB 390.71 KB 71.07 KB 71.07 KB FB_WWW_PROD
react-dom-test-utils.development.js 0.0% -0.0% 57.19 KB 57.19 KB 15.74 KB 15.74 KB NODE_DEV
ReactDOMTesting-profiling.js 0.0% -0.0% 390.71 KB 390.71 KB 71.07 KB 71.07 KB FB_WWW_PROFILING
react-dom-server.node.development.js -0.7% -0.5% 129.73 KB 128.88 KB 34.53 KB 34.35 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 12.23 KB 12.23 KB 4.5 KB 4.5 KB NODE_PROD
react-dom-server.node.production.min.js 0.0% -0.0% 20.33 KB 20.33 KB 7.53 KB 7.53 KB NODE_PROD
react-dom-server.browser.development.js -0.7% -0.5% 128.51 KB 127.67 KB 34.27 KB 34.09 KB NODE_DEV
react-dom-server.browser.production.min.js 0.0% -0.0% 19.92 KB 19.92 KB 7.38 KB 7.38 KB NODE_PROD
react-dom.development.js -0.1% -0.1% 925.42 KB 924.3 KB 201.93 KB 201.69 KB UMD_DEV
react-dom.production.min.js 0.0% 0.0% 122.73 KB 122.73 KB 39.11 KB 39.12 KB UMD_PROD
ReactDOMForked-dev.js -0.1% -0.1% 965.89 KB 964.81 KB 214.11 KB 213.92 KB FB_WWW_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% 0.0% 10 KB 10 KB 3.36 KB 3.36 KB UMD_PROD
ReactDOMServer-dev.js -2.5% -2.7% 135.92 KB 132.46 KB 34.73 KB 33.79 KB FB_WWW_DEV
react-dom.profiling.min.js 0.0% 0.0% 126.55 KB 126.55 KB 40.36 KB 40.38 KB UMD_PROFILING
ReactDOMForked-prod.js 0.0% -0.0% 405.25 KB 405.25 KB 73.15 KB 73.15 KB FB_WWW_PROD
ReactDOMServer-prod.js 0.0% -0.0% 45.87 KB 45.87 KB 10.69 KB 10.69 KB FB_WWW_PROD
react-dom.development.js -0.1% -0.1% 881.21 KB 880.14 KB 199.47 KB 199.21 KB NODE_DEV
ReactDOMForked-profiling.js 0.0% -0.0% 416.06 KB 416.06 KB 74.96 KB 74.95 KB FB_WWW_PROFILING
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 53.21 KB 53.21 KB 13.65 KB 13.65 KB NODE_DEV
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 5.09 KB 5.09 KB 1.68 KB 1.67 KB NODE_DEV
react-dom.production.min.js -0.0% -0.0% 122.91 KB 122.9 KB 38.37 KB 38.36 KB NODE_PROD
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 9.75 KB 9.75 KB 3.25 KB 3.25 KB NODE_PROD
react-dom-unstable-fizz.node.production.min.js 0.0% -0.1% 1.17 KB 1.17 KB 667 B 666 B NODE_PROD

ReactDOM: size: 0.0%, gzip: -0.0%

Size changes (experimental)

Generated by 🚫 dangerJS against 8a8f18a

@sebmarkbage sebmarkbage merged commit 1fd4543 into facebook:master Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaearon gaearon gaearon approved these changes

+1 more reviewer

@awibox awibox awibox approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sebmarkbage @sizebot @gaearon @awibox @facebook-github-bot