React Event System: cleanup plugins + break out update batching logic #18503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5ceb334:
|
Details of bundled changes.Comparing: fe2cb52...5ceb334 react-dom
ReactDOM: size: 🔺+7.0%, gzip: 🔺+7.0% Size changes (stable) |
Details of bundled changes.Comparing: fe2cb52...5ceb334 react-dom
ReactDOM: size: 0.0%, gzip: -0.0% Size changes (experimental) |
Where does this happen? |
trueadm
force-pushed
the
simplify-plugins
branch
from
3644977
to
c55d56f
Compare
|
@gaearon Ah, well spotted. |
trueadm
force-pushed
the
simplify-plugins
branch
2 times, most recently
from
3502039
to
d4b691f
Compare
Include changes Fix bunch of issues Cleanup Fix
trueadm
force-pushed
the
simplify-plugins
branch
from
d4b691f
to
5ceb334
Compare
What are you saying here? This plugin wasn't injected by react-dom before and hasn't been removed either. |
Ah, I thought #18483 was merged already. I've updated the summary. |
necolas
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up a bunch of things with the existing plugin event system that should simplify things and also remove some of the indirection that exists when we try to share things between different renderers to keep things DRY but actually ship irrelevant parts of the code with that when we do.
ReactGenericBatching.jshas been forked for ReactDOM. That version is calledReactDOMUpdateBatching.jsand contains all the ReactDOM parts, which have been removed fromReactGenericBatching.js.ReactControlledComponent.jshas been moved into ReactDOM and has been renamedReactDOMControlledComponent.jsto reflect that no other renderer, but ReactDOM uses it.ReactTestUtilswith an inlined version ofrunEventsInBatchand removed the export from ReactDOM internals.