Allow flushSync to noop in life cycles but with a warning #18759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2b80075:
|
gaearon
approved these changes
Apr 28, 2020
This was referenced Mar 6, 2021
This was referenced Mar 14, 2021
This was referenced Mar 15, 2021
Merged
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already did this for flushControlled before.
It doesn't make sense to flush in a life-cycle or render because React can't do the work right then. Even if we did, it would make all other life-cycles more confusing.
There might be some opportunity by flushing right at the end of a React batch to do a second one. However, you can also call flush sync in the next tick to get more or less the same effect.
The only reason to relax this to a log is that it is very easy to accidentally add this to paths called from life-cycles since anything could call it. It might just be able to work in most cases.
In the case it's called from a layout effect, the priority of scheduled work will be sync anyway. In the case where it's called in passive effects, I could increase the priority but that's just a fallback case. It errors anyway. If it's in passive effects it full of race conditions anyway so probably it's fine to leave it like this.