React Flare: fix PressLegacy preventDefault issue #18904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cd8d909:
|
gaearon
approved these changes
May 13, 2020
|
Hi and a good day @trueadm . Please, how can I run a sample of react interactions lets say context menu in my front end application with the required flag enabled in my code or in my react build? Or for now it is only available for internal testing? Thanks for your anticipated response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently uncovered a bug in the PressLegacy responder in React Flare. @necolas found a bug that occurs because we call
preventDefaultforEnterkey presses. We should have only been doing this forSpacekey presses, otherwise it means we never get a correspondingclickfire, because callingpreventDefaultin the key press phase cancels out the click. This PR fixes that, and also fixes the test that had the wrong semantics.