Enable Context Menu on Chrome to inspect React Component #18939
Conversation
|
Hi @asheshvidyut7! Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
ghost
changed the title
ghost
changed the title
ghost
changed the title
ghost
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8f40aad:
|
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
ghost
marked this pull request as ready for review
ghost
mentioned this pull request
| @@ -40,7 +40,7 @@ | |||
| "persistent": false | |||
| }, | |||
|
|
|||
| "permissions": ["file:///*", "http://*/*", "https://*/*"], | |||
| "permissions": ["file:///*", "http://*/*", "https://*/*", "contextMenus"], | |||
There was a problem hiding this comment.
New permission added only to the Chrome manifest? How does this impact Firefox and Edge?
Can we add this new permission as an optional_permissions instead?
Maybe we could add an item to the settings menu, e.g. "Enable context menu", that prompts the user to grant the permission. It's not as convenient or discoverable but I'm wary about adding new required permissions. Might cause problems or complaints for people updating.
There was a problem hiding this comment.
Yes that's true. I think chrome will disable the extension, saying that the extension has been disabled as it requires additional permissions. Have to check if contextMenus can be requested as an optional permission. I think it should be
There was a problem hiding this comment.
Oh hi @rickhanlonii , actually I didn't work on this, I was just giving some PR comments.
I think @asheshvidyut7 is the author of the PR.
But I think contextMenu permission can be an optional permission as per the text below
https://developer.chrome.com/docs/extensions/reference/permissions/#step-2-declare-optional-permissions-in-the-manifest:~:text=Most%20Chrome%20extension%20permissions%20can%20be%20specified%20as%20optional%2C%20with%20the%20following%20exceptions.
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
|
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you! |
|
Is this still planned at all? |
Towards #18822
This PR adds a context menu on chrome. Clicking on the menu, react component is selected on Components tab.
It is my first PR, will need guidance.