Skip to content

Enable component stack locations in www #19047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2020
Merged

Enable component stack locations in www #19047

merged 1 commit into from
May 29, 2020

Conversation

@sebmarkbage
Copy link
Collaborator

@sebmarkbage sebmarkbage commented May 29, 2020 •
edited
Loading

I'd like to enable this everywhere but haven't tested it in RN yet and enabling it isomorphic would affect RN.

@sebmarkbage sebmarkbage requested review from bvaughn and gaearon May 29, 2020 19:32
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels May 29, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 29, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ec39cf8:

Sandbox Source
practical-davinci-t2joe Configuration

@sizebot
Copy link

sizebot commented May 29, 2020

Details of bundled changes.

Comparing: c03b866...ec39cf8

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js 0.0% -0.0% 910.76 KB 910.76 KB 206.32 KB 206.32 KB NODE_DEV
ReactDOMForked-prod.js -0.2% -0.2% 432.06 KB 431.35 KB 78.07 KB 77.92 KB FB_WWW_PROD
ReactDOMForked-profiling.js -0.2% -0.2% 442.59 KB 441.88 KB 79.81 KB 79.66 KB FB_WWW_PROFILING
react-dom-test-utils.production.min.js 0.0% -0.0% 13.18 KB 13.18 KB 4.9 KB 4.9 KB UMD_PROD
ReactDOMTesting-dev.js 0.0% -0.0% 937.33 KB 937.33 KB 209.45 KB 209.44 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% -0.0% 70.47 KB 70.47 KB 19.74 KB 19.74 KB NODE_DEV
ReactDOMTesting-prod.js 0.0% -0.0% 394.4 KB 394.4 KB 73.01 KB 73.01 KB FB_WWW_PROD
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 5.61 KB 5.61 KB 1.87 KB 1.86 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 13.06 KB 13.06 KB 4.81 KB 4.8 KB NODE_PROD
ReactTestUtils-dev.js -0.1% -0.1% 65.86 KB 65.77 KB 17.68 KB 17.67 KB FB_WWW_DEV
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 4.87 KB 4.87 KB 1.71 KB 1.7 KB NODE_DEV
react-dom.development.js 0.0% -0.0% 956.66 KB 956.66 KB 208.93 KB 208.93 KB UMD_DEV
react-dom.production.min.js 0.0% -0.0% 126.01 KB 126.01 KB 40.35 KB 40.34 KB UMD_PROD
react-dom.profiling.min.js 0.0% -0.0% 130.11 KB 130.11 KB 41.58 KB 41.58 KB UMD_PROFILING
ReactDOMForked-dev.js -0.2% -0.2% 1.02 MB 1.02 MB 233.46 KB 233.05 KB FB_WWW_DEV
ReactDOM-dev.js -0.2% -0.2% 1.02 MB 1.01 MB 231.33 KB 230.93 KB FB_WWW_DEV
ReactDOM-prod.js -0.2% -0.2% 434.75 KB 434.04 KB 77.05 KB 76.9 KB FB_WWW_PROD
react-dom-server.browser.development.js 0.0% -0.0% 137.35 KB 137.35 KB 36.47 KB 36.47 KB NODE_DEV
ReactDOM-profiling.js -0.2% -0.2% 446.21 KB 445.5 KB 78.95 KB 78.8 KB FB_WWW_PROFILING
react-dom-server.browser.production.min.js 0.0% -0.0% 20.26 KB 20.26 KB 7.51 KB 7.51 KB NODE_PROD
ReactDOMServer-dev.js -1.1% -1.1% 144.29 KB 142.63 KB 36.69 KB 36.29 KB FB_WWW_DEV

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactART-prod.js -0.3% -0.4% 243.73 KB 242.97 KB 41.58 KB 41.41 KB FB_WWW_PROD
react-art.development.js 0.0% -0.0% 672.59 KB 672.59 KB 141.55 KB 141.54 KB UMD_DEV
react-art.production.min.js 0.0% 0.0% 111.72 KB 111.72 KB 33.87 KB 33.87 KB UMD_PROD
react-art.development.js 0.0% -0.0% 575.18 KB 575.18 KB 123.8 KB 123.8 KB NODE_DEV
ReactART-dev.js -0.3% -0.4% 609.27 KB 607.39 KB 128.24 KB 127.74 KB FB_WWW_DEV

react

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-jsx-runtime.development.js 0.0% -0.0% 36.61 KB 36.61 KB 10.63 KB 10.62 KB NODE_DEV
react.development.js 0.0% -0.0% 112.14 KB 112.14 KB 27.19 KB 27.19 KB UMD_DEV
react-jsx-runtime.production.min.js 0.0% -0.2% 959 B 959 B 602 B 601 B NODE_PROD
react-unstable-cache.development.js 0.0% -0.2% 1.05 KB 1.05 KB 588 B 587 B NODE_DEV
react-unstable-cache.profiling.min.js 0.0% -0.2% 866 B 866 B 562 B 561 B NODE_PROFILING
react-jsx-dev-runtime.development.js 0.0% -0.0% 36.03 KB 36.03 KB 10.45 KB 10.45 KB NODE_DEV
react-jsx-dev-runtime.profiling.min.js 0.0% -0.3% 452 B 452 B 319 B 318 B NODE_PROFILING
JSXDEVRuntime-dev.js -4.1% -3.3% 40.25 KB 38.59 KB 11.2 KB 10.82 KB FB_WWW_DEV
react.production.min.js 0.0% -0.0% 12.49 KB 12.49 KB 4.88 KB 4.88 KB UMD_PROD
react.development.js 0.0% 0.0% 73.47 KB 73.47 KB 19.53 KB 19.53 KB NODE_DEV
react.production.min.js 0.0% -0.0% 7.5 KB 7.5 KB 2.96 KB 2.96 KB NODE_PROD
React-dev.js -1.7% -1.6% 98.88 KB 97.22 KB 24.05 KB 23.66 KB FB_WWW_DEV

ReactDOM: size: 0.0%, gzip: -0.0%

React: size: 0.0%, gzip: -0.0%

Size changes (experimental)

Generated by 🚫 dangerJS against ec39cf8

@sizebot
Copy link

sizebot commented May 29, 2020

Details of bundled changes.

Comparing: c03b866...ec39cf8

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js 0.0% -0.0% 876.81 KB 876.81 KB 199.69 KB 199.69 KB NODE_DEV
ReactDOMForked-prod.js -0.2% -0.2% 443.25 KB 442.54 KB 79.94 KB 79.79 KB FB_WWW_PROD
react-dom-server.node.development.js 0.0% -0.0% 131.63 KB 131.63 KB 34.97 KB 34.97 KB NODE_DEV
ReactDOMForked-profiling.js -0.2% -0.2% 453.84 KB 453.13 KB 81.7 KB 81.55 KB FB_WWW_PROFILING
react-dom-test-utils.development.js 0.0% -0.0% 70.46 KB 70.46 KB 19.73 KB 19.73 KB NODE_DEV
ReactDOMTesting-prod.js 0.0% -0.0% 406.25 KB 406.25 KB 74.89 KB 74.89 KB FB_WWW_PROD
react-dom-test-utils.production.min.js 0.0% -0.0% 13.05 KB 13.05 KB 4.8 KB 4.8 KB NODE_PROD
ReactTestUtils-dev.js -0.1% -0.1% 65.86 KB 65.77 KB 17.67 KB 17.66 KB FB_WWW_DEV
react-dom.development.js 0.0% -0.0% 921.18 KB 921.18 KB 202.23 KB 202.23 KB UMD_DEV
react-dom.production.min.js 0.0% -0.0% 121.05 KB 121.05 KB 38.84 KB 38.84 KB UMD_PROD
react-dom.profiling.min.js 0.0% -0.0% 125.02 KB 125.02 KB 40.08 KB 40.08 KB UMD_PROFILING
ReactDOMForked-dev.js -0.2% -0.2% 1.04 MB 1.04 MB 239.11 KB 238.74 KB FB_WWW_DEV
ReactDOM-dev.js -0.2% -0.2% 1.04 MB 1.04 MB 236.9 KB 236.52 KB FB_WWW_DEV
ReactDOM-prod.js -0.2% -0.2% 445.82 KB 445.11 KB 78.9 KB 78.75 KB FB_WWW_PROD
react-dom-server.browser.development.js 0.0% -0.0% 130.36 KB 130.36 KB 34.72 KB 34.72 KB NODE_DEV
ReactDOM-profiling.js -0.2% -0.2% 457.35 KB 456.64 KB 80.82 KB 80.67 KB FB_WWW_PROFILING
ReactDOMServer-dev.js -1.1% -1.0% 148.32 KB 146.67 KB 37.67 KB 37.29 KB FB_WWW_DEV

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactART-prod.js -0.3% -0.4% 250.76 KB 250.01 KB 42.82 KB 42.66 KB FB_WWW_PROD
react-art.development.js 0.0% -0.0% 646.59 KB 646.59 KB 136.25 KB 136.24 KB UMD_DEV
react-art.production.min.js 0.0% -0.0% 108.16 KB 108.16 KB 32.8 KB 32.8 KB UMD_PROD
react-art.development.js 0.0% -0.0% 550.27 KB 550.27 KB 118.68 KB 118.68 KB NODE_DEV
ReactART-dev.js -0.3% -0.4% 619.28 KB 617.4 KB 130.23 KB 129.72 KB FB_WWW_DEV

react

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-jsx-runtime.development.js 0.0% -0.0% 31.13 KB 31.13 KB 9.06 KB 9.05 KB NODE_DEV
react.development.js 0.0% -0.0% 102.27 KB 102.27 KB 24.71 KB 24.71 KB UMD_DEV
react-jsx-dev-runtime.development.js 0.0% -0.0% 30.54 KB 30.54 KB 8.88 KB 8.88 KB NODE_DEV
JSXDEVRuntime-dev.js -4.1% -3.3% 40.25 KB 38.59 KB 11.19 KB 10.82 KB FB_WWW_DEV
react.profiling.min.js 0.0% -0.0% 14.89 KB 14.89 KB 5.63 KB 5.62 KB UMD_PROFILING
react.development.js 0.0% -0.0% 64.08 KB 64.08 KB 17.15 KB 17.15 KB NODE_DEV
React-dev.js -1.7% -1.6% 99.87 KB 98.22 KB 24.24 KB 23.85 KB FB_WWW_DEV

Size changes (stable)

Generated by 🚫 dangerJS against ec39cf8

@sebmarkbage sebmarkbage merged commit 89edb0e into facebook:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaearon gaearon gaearon approved these changes

@bvaughn bvaughn Awaiting requested review from bvaughn

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sebmarkbage @sizebot @gaearon @facebook-github-bot