Re-enabled DebugTracing feature for old reconciler fork #19161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was temporarily removed by @sebmarkbage via PR facebook#18697. Newly re-added tracing is simplified, since the lane(s) data type does not require the (lossy) conversion between priority and expiration time values. @sebmarkbage mentioned that he removed this because it might get in the way of his planned discrete/sync refactor. I'm not sure if that concern still applies, but just in case- I have only re-added it to the old reconciler fork for now.
bvaughn
force-pushed
the
unrevert-debugTracing
branch
from
01451bb to
87860f5
Compare
facebook-github-bot
added
CLA Signed
React Core Team
bvaughn
referenced
this pull request
Jun 19, 2020
It was temporarily removed by @sebmarkbage via PR #18697. Newly re-added tracing is simplified, since the lane(s) data type does not require the (lossy) conversion between priority and expiration time values. @sebmarkbage mentioned that he removed this because it might get in the way of his planned discrete/sync refactor. I'm not sure if that concern still applies, but just in case- I have only re-added it to the old reconciler fork for now.
Details of bundled changes.Comparing: d1d9054...feb7b1a react-art
react-dom
ReactDOM: size: 0.0%, gzip: -0.0% Size changes (experimental) |
Details of bundled changes.Comparing: d1d9054...feb7b1a react-art
react-dom
ReactDOM: size: 0.0%, gzip: -0.0% Size changes (stable) |
|
CI failure from Code Sandbox is unrelated 😦
|
|
I had hoped to add a test that caught the previous regression, but I haven't been able to trigger it. As a sanity check, I also added an intentional Open to suggestions! |
|
@lunaruan is working on getting a repro so we can write a test that mimics the actual scenario that came up |
|
@acdlite Good to hear. I'll be happy to help her dig into this on Monday if she's interested 😄 Given that this PR is purely additive (some new logging, nothing moved around or otherwise changed) do you think the PR needs to block on that test? Seems pretty safe IMO. |
|
The only reason I would want to block the PR is to make sure we follow through on adding a test for the bug that manifested in www. The fact that we don't fully understand what happened implies to me that it's likely an important regression. I had asked @lunaruan not to land a fix without a test because 1) I don't think it's blocking anything, since the profiler work can use this PR as a reference, and 2) I'm guessing it won't take more than a day or two to narrow down the bug. But if you decide to merge without a test, I trust y'all to follow up with a test after. |
|
That makes sense. I'll check in with @lunaruan once she's in this morning about the test. I'll decide after talking to her whether I wait to reland this or not. |
|
Luna and I have been unable to repro this so far (either in a test or with application usage). We have a pairing session tomorrow to look into it with the person who reported the regression internally. Hopefully he can repro it while we're watching. I am going to reland this now. In my mind, the test is now decoupled from this PR anyway since this PR no longer moves anything around. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debug tracing was reverted in #19159 because of a regression in
commitRootImpl. This PR re-adds it without that regression.Original commit message
It was temporarily removed by @sebmarkbage via PR #18697. Newly re-added tracing is simplified, since the lane(s) data type does not require the (lossy) conversion between priority and expiration time values.
@sebmarkbage mentioned that he removed this because it might get in the way of his planned discrete/sync refactor. I'm not sure if that concern still applies, but just in case- I have only re-added it to the old reconciler fork for now.