Modern Event System: use focusin/focusout for onFocus/onBlur #19186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e8205ae:
|
bvaughn
approved these changes
Jun 24, 2020
Contributor
bvaughn
left a comment
bvaughn
left a comment
There was a problem hiding this comment.
I think this looks okay, obviously barring the JSDOM issue.
packages/react-dom/src/events/plugins/ModernChangeEventPlugin.js
Outdated
Show resolved
Hide resolved
packages/react-dom/src/events/plugins/ModernChangeEventPlugin.js
Outdated
Show resolved
Hide resolved
trueadm
force-pushed
the
focusin-focusout
branch
7 times, most recently
from
1326bb2 to
04209cb
Compare
gaearon
approved these changes
Jul 6, 2020
Collaborator
gaearon
left a comment
gaearon
left a comment
There was a problem hiding this comment.
Seems ok but I don't see why we don't remove TOP_FOCUS and TOP_BLUR altogether.
trueadm
force-pushed
the
focusin-focusout
branch
9 times, most recently
from
671aacc to
ff22629
Compare
gaearon
approved these changes
Jul 8, 2020
trueadm
force-pushed
the
focusin-focusout
branch
2 times, most recently
from
f709fb1 to
a196777
Compare
This was referenced Mar 15, 2021
Merged
adri1wald
added a commit
to adri1wald/slate
that referenced
this pull request
Mar 31, 2022
See facebook/react#19186 for details on changes to `onFocus` and `onBlur`
5 tasks
dylans
pushed a commit
to ianstormtaylor/slate
that referenced
this pull request
Apr 3, 2022
…lers in React >= 17 (#4920) * use focusin and focusout without capture if react >= 17 See facebook/react#19186 for details on changes to `onFocus` and `onBlur` * more accurate name for react version check const * add changeset * add comment about react >= 17 focus event listeners
thang2162
added a commit
to thang2162/m3r
that referenced
this pull request
May 24, 2023
Switched focus and blur out for focusin and focusout due to unintended side effect. React appears to have switch to using it even though it fires a warning. facebook/react#19186
tf
added a commit
to tf/floating-ui
that referenced
this pull request
Jul 23, 2024
React 17 switched to using `focusin`/`focusout` events for `onFocus`/`onBlur` [1]. floating-ui's focus manager appears to depend on this implicitly, causing focus to revert to body when tab-ing back into a floating portal with Reacht 16. Manually using `focusin`/`focusout` appears to fix the problem. [1] facebook/react#19186
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR requires changes in JSDOM, otherwise Jest tests fail. Everything passes when I make the JSDOM changes locally. This PR also includes #19221.
Before the changes in this PR, we mapped
onFocusandonBlurtofocusandblur, but we did so in the capture phase. Doing so in the capture phase enables us to listen to all events as if they bubbled, which works great when you listen on thedocument.With the modern event system, we no longer listen on the
documentfor events, but rather with listen to the React root (or portal) container element. This means that if we listen tofocusandblurin the capture phase, they actually occur in reverse order, which can lead to inconsistent UIs ifonFocusoronBlurare used likefocusinandfocusoutwork (which we have recommended users to do in the past).This PR alters how the modern event system handles
onFocusandonBlurso that they now usefocusinandfocusoutrather thanfocusandblur. This means we no longer need to listen to these events in the capture phase, ensuring consistentcy when usingonFocusandonBlurwith the expectation that bubbling order should correctly traverse through containers as expected.In terms of breaking changes, this change will mean that React will not support Firefox versions earlier than 52. Earlier versions do not support
focusinandfocusout.