Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some type detection #19239

Merged
merged 1 commit into from
Jul 2, 2020
Merged

Add some type detection #19239

merged 1 commit into from
Jul 2, 2020

Conversation

sunnibfgi
Copy link
Contributor

No description provided.

@bvaughn bvaughn requested a review from trueadm July 2, 2020 14:52
@bvaughn
Copy link
Contributor

bvaughn commented Jul 2, 2020 •
edited
Loading

cc @trueadm

Not sure if @flow annotations were omitted from these files intentionally? Looks like some others are also missing the pragma (e.g. SelectEventPlugin)

Edit Whoops this isn't new event stuff. This is old event stuff. I should have looked more carefully, sorry.

@trueadm trueadm merged commit cd9046f into facebook:master Jul 2, 2020
@trueadm
Copy link
Contributor

trueadm commented Jul 2, 2020 •
edited
Loading

Thanks for this! Update: this broke master, I have a follow up #19242 to fix it.

trueadm added a commit to trueadm/react that referenced this pull request Jul 2, 2020
@trueadm
Fix Flow from facebook#19239
04b00b6
@trueadm trueadm mentioned this pull request Jul 2, 2020
Merged
trueadm added a commit that referenced this pull request Jul 2, 2020
@trueadm
Fix Flow from #19239 (#19242)
65c1377
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueadm trueadm trueadm approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sunnibfgi @bvaughn @trueadm @facebook-github-bot