Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DevTools] Show HOC names in profiler #19283

Merged
merged 2 commits into from
Jul 10, 2020
Merged

[DevTools] Show HOC names in profiler #19283

merged 2 commits into from
Jul 10, 2020

Conversation

bl00mber
Copy link
Contributor

@bl00mber bl00mber commented Jul 8, 2020

close #19259
related #18802

Screenshot from 2020-07-09

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 8, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 84ad4f2:

Sandbox Source
React Configuration

@sizebot
Copy link

sizebot commented Jul 8, 2020 •
edited
Loading

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 84ad4f2

@sizebot
Copy link

sizebot commented Jul 8, 2020 •
edited
Loading

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 84ad4f2

@bl00mber bl00mber force-pushed the devtools/hoc-profiler-names branch 3 times, most recently from cce5986 to 5cb363d Compare July 8, 2020 20:22
@bl00mber bl00mber force-pushed the devtools/hoc-profiler-names branch from 5cb363d to e3530ab Compare July 8, 2020 20:53
@jyash97
Copy link
Contributor

jyash97 commented Jul 9, 2020

Hey @bl00mber

I have also created the PR for the same. Let me know if I need to close the PR. Here's the link: #19281

@bl00mber
Copy link
Contributor Author

bl00mber commented Jul 9, 2020

@jyash97 my method of passing the value may be better, however your idea with badges seems interesting. The color of badges on your video is indistinguishable from the blocks on which they are placed: maybe they need to be rendered white. If it will be considered appropriate by react developers I may integrate badges to this PR with your credit.

@jyash97
Copy link
Contributor

jyash97 commented Jul 9, 2020

@bl00mber I agree the way you are passing the values is way better than I did as I wasnt aware of the full codebase so I did what I could figure out.

We can wait for brian or other react team members for the next steps here.

Thanks for looking into the PR. 😁

@bvaughn bvaughn self-assigned this Jul 9, 2020
@bvaughn
Copy link
Contributor

bvaughn commented Jul 9, 2020

I will review both in the morning. I believe I have an initial preference for the UI shown on this PR but we'll see when I dig in.

@bvaughn bvaughn mentioned this pull request Jul 10, 2020
Closed
bvaughn
bvaughn approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dig it. Thanks~

@bvaughn bvaughn merged commit 17efbf7 into facebook:master Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvaughn bvaughn bvaughn approved these changes

Assignees

@bvaughn bvaughn

Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggestion: show HOC names in profiler
5 participants
@bl00mber @sizebot @jyash97 @bvaughn @facebook-github-bot