Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Trying to solve #18051 and #18937 .
exhaustive-deps
eslint rule does not recognize aJSXIdentifier
as needed dependency.This is because eslint scope
.references
does not include JSX.I have pushed only a failing test with the aim to keep on working on it.
Test Plan
Failing test where an hook uses a
JSXIdentifier
that is properly added to deps array while the eslint rules marks it as unnecessary.