Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

act should work without mock Scheduler #19789

Closed
wants to merge 1 commit into from
Closed

act should work without mock Scheduler #19789

wants to merge 1 commit into from

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Sep 8, 2020 •
edited
Loading

Updates act so that it works in Concurrent and Blocking Mode without a mock Scheduler.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Sep 8, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 8, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit eadf277:

Sandbox Source
React Configuration

@acdlite acdlite mentioned this pull request Sep 9, 2020
Merged
@acdlite
act should work without mock Scheduler
eadf277 
Updates `act` so that it works in Concurrent and Blocking Mode without
a mock Scheduler.
@acdlite acdlite force-pushed the act-without-scheduler-mock branch from 0c0db27 to eadf277 Compare September 9, 2020 19:25
@sizebot
Copy link

sizebot commented Sep 9, 2020

Details of bundled changes.

Comparing: e7b2553...eadf277

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js 0.0% -0.1% 910.7 KB 910.76 KB 207.66 KB 207.54 KB NODE_DEV
ReactDOMForked-prod.js 🔺+0.1% 0.0% 379.93 KB 380.23 KB 70.75 KB 70.76 KB FB_WWW_PROD
react-dom-server.node.development.js 0.0% -0.0% 138.57 KB 138.57 KB 36.59 KB 36.59 KB NODE_DEV
react-dom.production.min.js 🔺+0.1% 🔺+0.1% 123.39 KB 123.47 KB 39.87 KB 39.89 KB NODE_PROD
ReactDOMForked-profiling.js +0.1% 0.0% 393.37 KB 393.67 KB 73.22 KB 73.23 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% -0.0% 144.73 KB 144.73 KB 36.77 KB 36.77 KB UMD_DEV
react-dom-server.node.production.min.js 0.0% -0.0% 20.66 KB 20.66 KB 7.65 KB 7.65 KB NODE_PROD
react-dom-test-utils.production.min.js 0.0% -0.0% 12.83 KB 12.83 KB 5.02 KB 5.02 KB UMD_PROD
ReactDOMTesting-dev.js -0.1% -0.1% 912.55 KB 911.95 KB 205.81 KB 205.65 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% -0.0% 59.93 KB 59.93 KB 17.52 KB 17.52 KB NODE_DEV
ReactDOMTesting-prod.js 🔺+0.1% 0.0% 375.03 KB 375.33 KB 70.77 KB 70.8 KB FB_WWW_PROD
react-dom-unstable-fizz.node.development.js 0.0% +0.1% 5.52 KB 5.52 KB 1.84 KB 1.84 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 12.69 KB 12.69 KB 4.94 KB 4.94 KB NODE_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 5.25 KB 5.25 KB 1.78 KB 1.78 KB UMD_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% -0.3% 1.17 KB 1.17 KB 668 B 666 B NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.3% 1.22 KB 1.22 KB 713 B 711 B UMD_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 4.78 KB 4.78 KB 1.68 KB 1.68 KB NODE_DEV
react-dom.development.js 0.0% -0.1% 957 KB 957.12 KB 210.31 KB 210.2 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.3% 1.01 KB 1.01 KB 617 B 615 B NODE_PROD
react-dom.production.min.js 🔺+0.1% 0.0% 123.21 KB 123.28 KB 40.62 KB 40.63 KB UMD_PROD
react-dom.profiling.min.js +0.1% -0.0% 128.46 KB 128.54 KB 42.25 KB 42.24 KB UMD_PROFILING
ReactDOMForked-dev.js -0.1% -0.1% 966.17 KB 965.56 KB 215.84 KB 215.66 KB FB_WWW_DEV
react-dom.profiling.min.js +0.1% 0.0% 128.83 KB 128.91 KB 41.55 KB 41.57 KB NODE_PROFILING
react-dom-server.browser.production.min.js 0.0% -0.0% 20.34 KB 20.34 KB 7.55 KB 7.55 KB UMD_PROD
ReactDOM-dev.js -0.1% -0.1% 965.49 KB 964.89 KB 216.33 KB 216.15 KB FB_WWW_DEV
ReactDOM-prod.js 🔺+0.1% 0.0% 379.5 KB 379.8 KB 70.54 KB 70.56 KB FB_WWW_PROD
react-dom-server.browser.development.js 0.0% -0.0% 137.3 KB 137.3 KB 36.34 KB 36.34 KB NODE_DEV
ReactDOM-profiling.js +0.1% 0.0% 392.66 KB 392.96 KB 72.99 KB 73.01 KB FB_WWW_PROFILING
react-dom-server.browser.production.min.js 0.0% -0.0% 20.24 KB 20.24 KB 7.5 KB 7.5 KB NODE_PROD
ReactDOMServer-dev.js 0.0% -0.0% 141.59 KB 141.59 KB 36.3 KB 36.3 KB FB_WWW_DEV
ReactDOMServer-prod.js 0.0% -0.0% 46.44 KB 46.44 KB 10.83 KB 10.83 KB FB_WWW_PROD
react-dom-test-utils.development.js 0.0% -0.0% 64.85 KB 64.85 KB 18.02 KB 18.02 KB UMD_DEV

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.development.js 0.0% -0.1% 645.96 KB 646.02 KB 138.2 KB 138.07 KB NODE_DEV
react-reconciler-reflection.development.js 0.0% -0.0% 16.61 KB 16.61 KB 4.96 KB 4.96 KB NODE_DEV
react-reconciler.production.min.js 🔺+0.1% 🔺+0.1% 86.06 KB 86.14 KB 26.54 KB 26.56 KB NODE_PROD
react-reconciler-reflection.production.min.js 0.0% -0.1% 2.8 KB 2.8 KB 1.16 KB 1.16 KB NODE_PROD
react-reconciler.profiling.min.js +0.1% +0.1% 91.47 KB 91.55 KB 28.2 KB 28.21 KB NODE_PROFILING

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactART-prod.js 0.0% 0.0% 232.96 KB 233.04 KB 41.35 KB 41.37 KB FB_WWW_PROD
react-art.development.js -0.1% -0.3% 687.13 KB 686.16 KB 146.1 KB 145.67 KB UMD_DEV
react-art.production.min.js 0.0% 0.0% 111.23 KB 111.24 KB 34.58 KB 34.58 KB UMD_PROD
react-art.development.js -0.2% -0.3% 588.48 KB 587.52 KB 128.23 KB 127.83 KB NODE_DEV
react-art.production.min.js 0.0% -0.0% 76.12 KB 76.13 KB 23.66 KB 23.66 KB NODE_PROD
ReactART-dev.js -0.3% -0.4% 615.07 KB 613.46 KB 131.1 KB 130.61 KB FB_WWW_DEV

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js 0.0% -0.1% 601.42 KB 601.52 KB 127.15 KB 127.02 KB UMD_DEV
react-test-renderer.production.min.js 🔺+0.1% 🔺+0.3% 76.3 KB 76.38 KB 24.03 KB 24.1 KB UMD_PROD
react-test-renderer.development.js 0.0% -0.1% 572.9 KB 572.96 KB 125.67 KB 125.54 KB NODE_DEV
react-test-renderer.production.min.js 🔺+0.1% 🔺+0.1% 76.09 KB 76.17 KB 23.72 KB 23.75 KB NODE_PROD
ReactTestRenderer-dev.js -0.1% -0.1% 587.96 KB 587.35 KB 126.78 KB 126.6 KB FB_WWW_DEV
ReactTestRenderer-dev.js -0.0% -0.1% 582.62 KB 582.54 KB 126.54 KB 126.4 KB RN_FB_DEV
ReactTestRenderer-prod.js 🔺+0.1% 🔺+0.1% 229.18 KB 229.48 KB 41.9 KB 41.92 KB RN_FB_PROD
ReactTestRenderer-profiling.js +0.1% 0.0% 240.52 KB 240.83 KB 44.04 KB 44.06 KB RN_FB_PROFILING

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js -0.1% -0.2% 673.08 KB 672.09 KB 146.48 KB 146.14 KB RN_OSS_DEV
ReactNativeRenderer-prod.js 0.0% 0.0% 267.89 KB 267.96 KB 47.89 KB 47.9 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js 0.0% 0.0% 279.36 KB 279.43 KB 50.09 KB 50.1 KB RN_OSS_PROFILING
ReactFabric-dev.js -0.2% -0.3% 653.73 KB 652.65 KB 141.83 KB 141.42 KB RN_OSS_DEV
ReactFabric-prod.js 0.0% 0.0% 261.6 KB 261.67 KB 46.6 KB 46.61 KB RN_OSS_PROD
ReactFabric-profiling.js 0.0% 0.0% 273.16 KB 273.23 KB 48.81 KB 48.82 KB RN_OSS_PROFILING

ReactDOM: size: 0.0%, gzip: -0.0%

Size changes (experimental)

Generated by 🚫 dangerJS against eadf277

@sizebot
Copy link

sizebot commented Sep 9, 2020

Details of bundled changes.

Comparing: e7b2553...eadf277

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js 0.0% -0.1% 875.25 KB 875.31 KB 201.16 KB 201.04 KB NODE_DEV
ReactDOMForked-prod.js 🔺+0.1% 0.0% 391.09 KB 391.4 KB 72.51 KB 72.52 KB FB_WWW_PROD
react-dom-server.node.development.js 0.0% -0.0% 137.06 KB 137.06 KB 36.37 KB 36.37 KB NODE_DEV
react-dom.production.min.js 🔺+0.1% 0.0% 118.83 KB 118.91 KB 38.56 KB 38.58 KB NODE_PROD
ReactDOMForked-profiling.js +0.1% 0.0% 404.58 KB 404.88 KB 75 KB 75.01 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% -0.0% 143.14 KB 143.14 KB 36.58 KB 36.57 KB UMD_DEV
react-dom-server.node.production.min.js 0.0% -0.0% 20.2 KB 20.2 KB 7.58 KB 7.58 KB NODE_PROD
react-dom-test-utils.production.min.js 0.0% -0.0% 12.82 KB 12.82 KB 5.02 KB 5.01 KB UMD_PROD
ReactDOMTesting-dev.js -0.1% -0.1% 940.64 KB 940.03 KB 211.35 KB 211.21 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% -0.0% 59.92 KB 59.92 KB 17.51 KB 17.51 KB NODE_DEV
ReactDOMTesting-prod.js 🔺+0.1% 0.0% 387.67 KB 387.98 KB 72.87 KB 72.89 KB FB_WWW_PROD
react-dom-test-utils.production.min.js 0.0% -0.0% 12.68 KB 12.68 KB 4.93 KB 4.93 KB NODE_PROD
react-dom.development.js 0.0% -0.1% 919.8 KB 919.93 KB 203.7 KB 203.57 KB UMD_DEV
react-dom.production.min.js 🔺+0.1% 0.0% 118.72 KB 118.79 KB 39.26 KB 39.28 KB UMD_PROD
react-dom.profiling.min.js +0.1% 0.0% 122.61 KB 122.69 KB 40.45 KB 40.47 KB UMD_PROFILING
ReactDOMForked-dev.js -0.1% -0.1% 991.69 KB 991.08 KB 220.61 KB 220.44 KB FB_WWW_DEV
react-dom.profiling.min.js +0.1% 0.0% 122.9 KB 122.98 KB 39.77 KB 39.79 KB NODE_PROFILING
react-dom-server.browser.production.min.js 0.0% -0.0% 19.88 KB 19.88 KB 7.46 KB 7.46 KB UMD_PROD
ReactDOM-dev.js -0.1% -0.1% 991.01 KB 990.41 KB 221.06 KB 220.88 KB FB_WWW_DEV
ReactDOM-prod.js 🔺+0.1% 0.0% 390.66 KB 390.96 KB 72.26 KB 72.27 KB FB_WWW_PROD
react-dom-server.browser.development.js 0.0% -0.0% 135.79 KB 135.79 KB 36.13 KB 36.12 KB NODE_DEV
ReactDOM-profiling.js +0.1% 0.0% 403.87 KB 404.17 KB 74.7 KB 74.71 KB FB_WWW_PROFILING
react-dom-server.browser.production.min.js 0.0% -0.0% 19.78 KB 19.78 KB 7.42 KB 7.42 KB NODE_PROD
ReactDOMServer-dev.js 0.0% -0.0% 145.62 KB 145.62 KB 37.31 KB 37.31 KB FB_WWW_DEV
ReactDOMServer-prod.js 0.0% -0.0% 47.3 KB 47.3 KB 11.04 KB 11.04 KB FB_WWW_PROD
react-dom-test-utils.development.js 0.0% -0.0% 64.84 KB 64.84 KB 18.01 KB 18.01 KB UMD_DEV

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js -0.2% -0.3% 678.47 KB 676.95 KB 147.34 KB 146.96 KB RN_FB_DEV
ReactFabric-dev.js -0.2% -0.3% 659.12 KB 657.51 KB 142.71 KB 142.25 KB RN_FB_DEV
ReactNativeRenderer-dev.js -0.1% -0.2% 673.07 KB 672.08 KB 146.47 KB 146.13 KB RN_OSS_DEV
ReactFabric-prod.js 0.0% 0.0% 261.55 KB 261.62 KB 46.58 KB 46.58 KB RN_FB_PROD
ReactNativeRenderer-prod.js 0.0% 0.0% 267.87 KB 267.94 KB 47.88 KB 47.89 KB RN_OSS_PROD
ReactFabric-profiling.js 0.0% 0.0% 273.1 KB 273.17 KB 48.79 KB 48.79 KB RN_FB_PROFILING
ReactNativeRenderer-profiling.js 0.0% 0.0% 279.35 KB 279.42 KB 50.08 KB 50.09 KB RN_OSS_PROFILING
ReactNativeRenderer-prod.js 0.0% 0.0% 267.83 KB 267.9 KB 47.86 KB 47.87 KB RN_FB_PROD
ReactNativeRenderer-profiling.js 0.0% 0.0% 279.3 KB 279.37 KB 50.06 KB 50.07 KB RN_FB_PROFILING
ReactFabric-dev.js -0.2% -0.3% 653.72 KB 652.64 KB 141.82 KB 141.41 KB RN_OSS_DEV
ReactFabric-prod.js 0.0% 0.0% 261.59 KB 261.65 KB 46.59 KB 46.6 KB RN_OSS_PROD
ReactFabric-profiling.js 0.0% 0.0% 273.14 KB 273.21 KB 48.81 KB 48.81 KB RN_OSS_PROFILING

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.development.js 0.0% -0.1% 617.84 KB 617.9 KB 132.71 KB 132.58 KB NODE_DEV
react-reconciler-reflection.development.js 0.0% -0.0% 16.6 KB 16.6 KB 4.95 KB 4.95 KB NODE_DEV
react-reconciler.production.min.js 🔺+0.1% 🔺+0.1% 82.77 KB 82.84 KB 25.64 KB 25.66 KB NODE_PROD
react-reconciler-reflection.production.min.js 0.0% -0.1% 2.79 KB 2.79 KB 1.15 KB 1.15 KB NODE_PROD
react-reconciler.profiling.min.js +0.1% +0.1% 86.8 KB 86.88 KB 26.88 KB 26.9 KB NODE_PROFILING

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactART-prod.js 0.0% 0.0% 240.12 KB 240.18 KB 42.61 KB 42.62 KB FB_WWW_PROD
react-art.development.js -0.1% -0.3% 660.23 KB 659.25 KB 141.09 KB 140.68 KB UMD_DEV
react-art.production.min.js 0.0% 0.0% 108.32 KB 108.33 KB 33.73 KB 33.73 KB UMD_PROD
react-art.development.js -0.2% -0.3% 562.84 KB 561.88 KB 123.33 KB 122.91 KB NODE_DEV
react-art.production.min.js 0.0% -0.0% 73.27 KB 73.28 KB 22.83 KB 22.83 KB NODE_PROD
ReactART-dev.js -0.3% -0.4% 625.08 KB 623.47 KB 133.13 KB 132.64 KB FB_WWW_DEV

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js 0.0% -0.1% 601.39 KB 601.49 KB 127.13 KB 127 KB UMD_DEV
react-test-renderer.production.min.js 🔺+0.1% 🔺+0.3% 76.27 KB 76.35 KB 24.01 KB 24.08 KB UMD_PROD
react-test-renderer.development.js 0.0% -0.1% 572.88 KB 572.93 KB 125.65 KB 125.53 KB NODE_DEV
react-test-renderer.production.min.js 🔺+0.1% 🔺+0.1% 76.06 KB 76.14 KB 23.71 KB 23.73 KB NODE_PROD
ReactTestRenderer-dev.js -0.1% -0.1% 587.95 KB 587.33 KB 126.77 KB 126.59 KB FB_WWW_DEV
ReactTestRenderer-dev.js -0.0% -0.1% 582.61 KB 582.52 KB 126.53 KB 126.39 KB RN_FB_DEV
ReactTestRenderer-prod.js 🔺+0.1% 🔺+0.1% 229.16 KB 229.46 KB 41.89 KB 41.92 KB RN_FB_PROD
ReactTestRenderer-profiling.js +0.1% 0.0% 240.51 KB 240.81 KB 44.03 KB 44.05 KB RN_FB_PROFILING

ReactDOM: size: 0.0%, gzip: -0.0%

Size changes (stable)

Generated by 🚫 dangerJS against eadf277

@acdlite
Copy link
Collaborator Author

acdlite commented Jun 22, 2021

Going to open a new version of this

@acdlite acdlite closed this Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acdlite @sizebot @facebook-github-bot