Reverts PR #19827 #19852
Merged
Reverts PR #19827 #19852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvaughn
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 80d0f2f:
|
rickhanlonii
approved these changes
Sep 17, 2020
facebook-github-bot
added
CLA Signed
React Core Team
todortotev
pushed a commit
to todortotev/react
that referenced
this pull request
Sep 18, 2020
…19827)" (facebook#19852) This reverts commit ec39a5e.
20547
referenced
this pull request
Oct 24, 2020
This package is missing the license attribute (or a license file). Being a sub-package of React, it should get the same license, however, none was specified. A scan with `license_checker` would recognize this as `UNKNOWN`.
koto
pushed a commit
to koto/react
that referenced
this pull request
Jun 15, 2021
…19827)" (facebook#19852) This reverts commit ec39a5e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts PR #19827
That change broke the development test harness.
To repro:
My concern is that this change may have broken the
react-devtools-inlinepackage in general which may also affect other integration targets (e.g. Code Sandbox).