Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Land effects refactor in main fork #20133

Closed
wants to merge 3 commits into from
Closed

Land effects refactor in main fork #20133

wants to merge 3 commits into from

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Oct 29, 2020

yarn replace-fork
yarn lint --fix

I also updated the eslint config to remove subtreeTags from list of disallowed fields in the old fork.

Will wait to land this until we confirm that the performance regression was fixed. Day 1 of results were good.

@acdlite
Check for deletions in hadNoMutationsEffects
ad8d4bc 
When detecting if a host tree was changed, we must check for deletions
in addition to mounts and updates.
@acdlite
Land effects refactor in main fork
763d5f2 
yarn replace-fork
yarn lint --fix

I also updated the eslint config to remove `subtreeTags` from list
of disallowed fields in the old fork.
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Oct 29, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 29, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4ed1b92:

Sandbox Source
React Configuration

@sizebot
Copy link

sizebot commented Oct 29, 2020 •
edited
Loading

Details of bundled changes.

Comparing: 343d7a4...4ed1b92

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js +0.6% +0.3% 872.67 KB 877.78 KB 199.75 KB 200.36 KB NODE_DEV
react-dom-server.node.development.js 0.0% -0.0% 137.05 KB 137.05 KB 36.37 KB 36.37 KB NODE_DEV
react-dom.production.min.js 🔺+0.5% 🔺+0.8% 117.75 KB 118.38 KB 37.95 KB 38.27 KB NODE_PROD
ReactDOMTesting-dev.js +0.6% +0.5% 940.73 KB 945.93 KB 210.75 KB 211.74 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% -0.0% 66.27 KB 66.27 KB 18.83 KB 18.83 KB NODE_DEV
ReactDOMTesting-prod.js 🔺+1.2% 🔺+1.3% 384.74 KB 389.41 KB 72.38 KB 73.33 KB FB_WWW_PROD
react-dom.development.js +0.6% +0.3% 917.09 KB 922.56 KB 202.29 KB 202.92 KB UMD_DEV
react-dom.production.min.js 🔺+0.5% 🔺+0.8% 117.65 KB 118.28 KB 38.64 KB 38.95 KB UMD_PROD
react-dom.profiling.min.js +0.7% +0.8% 121.55 KB 122.38 KB 39.85 KB 40.17 KB UMD_PROFILING
ReactDOMForked-dev.js 0.0% -0.0% 996.1 KB 996.1 KB 219.89 KB 219.89 KB FB_WWW_DEV
react-dom.profiling.min.js +0.7% +0.9% 121.83 KB 122.64 KB 39.13 KB 39.47 KB NODE_PROFILING
ReactDOM-dev.js +1.7% +1.1% 980.74 KB 997.39 KB 218.01 KB 220.39 KB FB_WWW_DEV
ReactDOM-prod.js 🔺+1.2% 🔺+1.4% 381.46 KB 385.96 KB 70.32 KB 71.29 KB FB_WWW_PROD
ReactDOM-profiling.js +1.8% +1.7% 395.14 KB 402.43 KB 72.79 KB 74.02 KB FB_WWW_PROFILING
ReactDOMServer-dev.js 0.0% -0.0% 145.51 KB 145.51 KB 37.29 KB 37.29 KB FB_WWW_DEV
ReactDOMServer-prod.js 0.0% 0.0% 47.29 KB 47.29 KB 11.03 KB 11.03 KB FB_WWW_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactART-prod.js 🔺+1.7% 🔺+2.1% 240.52 KB 244.54 KB 42.52 KB 43.4 KB FB_WWW_PROD
react-art.development.js +0.9% +0.4% 664.65 KB 670.36 KB 141.64 KB 142.24 KB UMD_DEV
react-art.production.min.js 🔺+0.5% 🔺+1.1% 108.52 KB 109.11 KB 33.72 KB 34.08 KB UMD_PROD
react-art.development.js +0.9% +0.5% 567.05 KB 572.4 KB 123.85 KB 124.45 KB NODE_DEV
react-art.production.min.js 🔺+0.8% 🔺+1.5% 73.47 KB 74.06 KB 22.84 KB 23.19 KB NODE_PROD
ReactART-dev.js +2.7% +1.9% 632.23 KB 648.98 KB 134.24 KB 136.8 KB FB_WWW_DEV

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js +0.9% +0.5% 682.72 KB 688.74 KB 147.83 KB 148.5 KB RN_FB_DEV
ReactFabric-dev.js +1.0% +0.7% 663.48 KB 670.07 KB 143.2 KB 144.26 KB RN_FB_DEV
ReactNativeRenderer-dev.js +0.9% +0.4% 677.32 KB 683.35 KB 146.97 KB 147.63 KB RN_OSS_DEV
ReactFabric-prod.js 🔺+0.9% 🔺+1.4% 261.58 KB 264.05 KB 46.51 KB 47.17 KB RN_FB_PROD
ReactNativeRenderer-prod.js 🔺+1.2% 🔺+1.6% 267.78 KB 270.88 KB 47.78 KB 48.56 KB RN_OSS_PROD
ReactFabric-profiling.js +1.1% +1.3% 272.96 KB 276.01 KB 48.71 KB 49.35 KB RN_FB_PROFILING
ReactNativeRenderer-profiling.js +1.3% +1.7% 279.31 KB 282.85 KB 49.98 KB 50.84 KB RN_OSS_PROFILING
ReactNativeRenderer-prod.js 🔺+1.2% 🔺+1.6% 267.74 KB 270.84 KB 47.77 KB 48.54 KB RN_FB_PROD
ReactNativeRenderer-profiling.js +1.3% +1.7% 279.26 KB 282.8 KB 49.96 KB 50.82 KB RN_FB_PROFILING
ReactFabric-dev.js +1.0% +0.7% 658.07 KB 664.67 KB 142.33 KB 143.38 KB RN_OSS_DEV
ReactFabric-prod.js 🔺+0.9% 🔺+1.4% 261.61 KB 264.09 KB 46.53 KB 47.18 KB RN_OSS_PROD
ReactFabric-profiling.js +1.1% +1.3% 273 KB 276.05 KB 48.73 KB 49.37 KB RN_OSS_PROFILING

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.development.js +0.9% +0.5% 622.16 KB 628 KB 133.24 KB 133.93 KB NODE_DEV
react-reconciler.production.min.js 🔺+0.9% 🔺+1.5% 82.96 KB 83.73 KB 25.65 KB 26.02 KB NODE_PROD
react-reconciler-reflection.production.min.js 0.0% -0.1% 2.79 KB 2.79 KB 1.15 KB 1.15 KB NODE_PROD
react-reconciler.profiling.min.js +1.1% +1.5% 87.02 KB 87.98 KB 26.86 KB 27.25 KB NODE_PROFILING

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js +0.9% +0.5% 605.82 KB 611.57 KB 127.66 KB 128.28 KB UMD_DEV
react-test-renderer.production.min.js 🔺+0.8% 🔺+1.6% 76.46 KB 77.04 KB 23.98 KB 24.38 KB UMD_PROD
react-test-renderer.development.js +0.9% +0.5% 577.09 KB 582.48 KB 126.18 KB 126.83 KB NODE_DEV
react-test-renderer.production.min.js 🔺+0.8% 🔺+1.5% 76.27 KB 76.85 KB 23.68 KB 24.03 KB NODE_PROD
ReactTestRenderer-dev.js +1.0% +0.7% 592.18 KB 598.17 KB 127.3 KB 128.21 KB FB_WWW_DEV
ReactTestRenderer-dev.js +1.0% +0.6% 586.86 KB 592.92 KB 127.08 KB 127.79 KB RN_FB_DEV
ReactTestRenderer-prod.js 🔺+1.4% 🔺+1.9% 229.12 KB 232.28 KB 41.81 KB 42.6 KB RN_FB_PROD
ReactTestRenderer-profiling.js +1.5% +1.8% 240.53 KB 244.13 KB 43.96 KB 44.74 KB RN_FB_PROFILING

Size changes (stable)

Generated by 🚫 dangerJS against 4ed1b92

@sizebot
Copy link

sizebot commented Oct 29, 2020 •
edited
Loading

Details of bundled changes.

Comparing: 343d7a4...4ed1b92

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js +0.7% +0.4% 908.22 KB 914.86 KB 206.3 KB 207.14 KB NODE_DEV
ReactDOMForked-prod.js 0.0% 0.0% 374.41 KB 374.41 KB 69.47 KB 69.47 KB FB_WWW_PROD
react-dom.production.min.js 🔺+0.5% 🔺+0.8% 122.29 KB 122.93 KB 39.3 KB 39.62 KB NODE_PROD
ReactDOMForked-profiling.js 0.0% 0.0% 390.83 KB 390.83 KB 72.19 KB 72.2 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% -0.0% 144.72 KB 144.72 KB 36.76 KB 36.76 KB UMD_DEV
ReactDOMTesting-dev.js +0.6% +0.5% 912.39 KB 917.6 KB 205.23 KB 206.23 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% -0.0% 66.28 KB 66.28 KB 18.84 KB 18.84 KB NODE_DEV
ReactDOMTesting-prod.js 🔺+1.2% 🔺+1.5% 371.68 KB 376.22 KB 70.18 KB 71.2 KB FB_WWW_PROD
react-dom-unstable-fizz.node.production.min.js 0.0% 🔺+0.2% 1.17 KB 1.17 KB 666 B 667 B NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.1% 1.22 KB 1.22 KB 712 B 713 B UMD_PROD
react-dom.development.js +0.7% +0.4% 954.39 KB 961.45 KB 208.87 KB 209.77 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.2% 1.01 KB 1.01 KB 616 B 617 B NODE_PROD
react-dom.production.min.js 🔺+0.5% 🔺+0.8% 122.12 KB 122.77 KB 40.02 KB 40.33 KB UMD_PROD
react-dom.profiling.min.js +0.8% +0.8% 127.38 KB 128.39 KB 41.65 KB 41.99 KB UMD_PROFILING
ReactDOMForked-dev.js 0.0% 0.0% 970.52 KB 970.52 KB 215.11 KB 215.11 KB FB_WWW_DEV
react-dom.profiling.min.js +0.8% +0.8% 127.73 KB 128.74 KB 40.96 KB 41.3 KB NODE_PROFILING
ReactDOM-dev.js +1.7% +1.1% 955.16 KB 971.81 KB 213.31 KB 215.69 KB FB_WWW_DEV
ReactDOM-prod.js 🔺+1.2% 🔺+1.6% 370.21 KB 374.64 KB 68.54 KB 69.65 KB FB_WWW_PROD
ReactDOM-profiling.js +1.9% +1.9% 383.84 KB 391.05 KB 71.03 KB 72.39 KB FB_WWW_PROFILING
ReactDOMServer-dev.js 0.0% -0.0% 141.48 KB 141.48 KB 36.28 KB 36.28 KB FB_WWW_DEV
ReactDOMServer-prod.js 0.0% 0.0% 46.43 KB 46.43 KB 10.82 KB 10.82 KB FB_WWW_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactART-prod.js 🔺+1.7% 🔺+2.1% 233.38 KB 237.33 KB 41.26 KB 42.14 KB FB_WWW_PROD
react-art.development.js +1.1% +0.6% 691.56 KB 698.85 KB 146.65 KB 147.57 KB UMD_DEV
react-art.production.min.js 🔺+0.5% 🔺+1.0% 111.41 KB 112 KB 34.58 KB 34.93 KB UMD_PROD
react-art.development.js +1.2% +0.6% 592.69 KB 599.57 KB 128.77 KB 129.6 KB NODE_DEV
react-art.production.min.js 🔺+0.8% 🔺+1.7% 76.3 KB 76.89 KB 23.68 KB 24.07 KB NODE_PROD
ReactART-dev.js +2.7% +1.9% 622.22 KB 638.97 KB 132.21 KB 134.78 KB FB_WWW_DEV

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.development.js +1.1% +0.6% 650.27 KB 657.65 KB 138.75 KB 139.6 KB NODE_DEV
react-reconciler-reflection.development.js 0.0% 0.0% 16.61 KB 16.61 KB 4.95 KB 4.95 KB NODE_DEV
react-reconciler.production.min.js 🔺+0.9% 🔺+1.3% 86.24 KB 87.01 KB 26.55 KB 26.89 KB NODE_PROD
react-reconciler-reflection.production.min.js 0.0% -0.1% 2.8 KB 2.8 KB 1.16 KB 1.16 KB NODE_PROD
react-reconciler.profiling.min.js +1.2% +1.5% 91.66 KB 92.8 KB 28.19 KB 28.61 KB NODE_PROFILING

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js +0.9% +0.5% 605.84 KB 611.59 KB 127.67 KB 128.3 KB UMD_DEV
react-test-renderer.production.min.js 🔺+0.8% 🔺+1.7% 76.49 KB 77.07 KB 24 KB 24.39 KB UMD_PROD
react-test-renderer.development.js +0.9% +0.5% 577.11 KB 582.5 KB 126.19 KB 126.85 KB NODE_DEV
react-test-renderer.production.min.js 🔺+0.8% 🔺+1.5% 76.29 KB 76.88 KB 23.7 KB 24.05 KB NODE_PROD
ReactTestRenderer-dev.js +1.0% +0.7% 592.2 KB 598.19 KB 127.31 KB 128.22 KB FB_WWW_DEV
ReactTestRenderer-dev.js +1.0% +0.6% 586.87 KB 592.94 KB 127.09 KB 127.8 KB RN_FB_DEV
ReactTestRenderer-prod.js 🔺+1.4% 🔺+1.9% 229.13 KB 232.3 KB 41.82 KB 42.6 KB RN_FB_PROD
ReactTestRenderer-profiling.js +1.5% +1.8% 240.54 KB 244.15 KB 43.97 KB 44.75 KB RN_FB_PROFILING

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js +0.9% +0.4% 677.34 KB 683.36 KB 146.98 KB 147.64 KB RN_OSS_DEV
ReactNativeRenderer-prod.js 🔺+1.2% 🔺+1.6% 267.79 KB 270.9 KB 47.79 KB 48.56 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js +1.3% +1.7% 279.32 KB 282.86 KB 49.99 KB 50.85 KB RN_OSS_PROFILING
ReactFabric-dev.js +1.0% +0.7% 658.09 KB 664.68 KB 142.34 KB 143.39 KB RN_OSS_DEV
ReactFabric-prod.js 🔺+0.9% 🔺+1.4% 261.63 KB 264.1 KB 46.53 KB 47.19 KB RN_OSS_PROD
ReactFabric-profiling.js +1.1% +1.3% 273.02 KB 276.07 KB 48.74 KB 49.38 KB RN_OSS_PROFILING

Size changes (experimental)

Generated by 🚫 dangerJS against 4ed1b92

@acdlite acdlite force-pushed the land-effects-refactor branch 3 times, most recently from 99a5f22 to 4ed1b92 Compare October 30, 2020 00:14
@gaearon
Copy link
Collaborator

gaearon commented Oct 30, 2020

oh hi 4ed1b92

@acdlite
Copy link
Collaborator Author

acdlite commented Oct 30, 2020

@gaearon I love cherry picking. So underrated.

@acdlite acdlite mentioned this pull request Nov 13, 2020
Merged
@sebmarkbage sebmarkbage deleted the branch facebook:master October 20, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickhanlonii rickhanlonii rickhanlonii approved these changes

@bvaughn bvaughn Awaiting requested review from bvaughn

@gaearon gaearon Awaiting requested review from gaearon

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@acdlite @sizebot @gaearon @rickhanlonii @sebmarkbage @facebook-github-bot