Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate ChildDeletion flag #20264

Merged
merged 1 commit into from
Nov 16, 2020
Merged

Commits on Nov 16, 2020

  1. Add separate ChildDeletion flag

    In the old, effect list implementation, the Deletion flag is is set on
    each deleted fiber.
    
    In the new, subtreeTag implementation, the Deletion flag is set on the
    parent of each deleted fiber, and the deleted fibers themselves are
    pushed to the `deletions` array.
    
    To better distinguish between these two uses, I've added a separate
    ChildDeletion flag. That way we can, if desired, maintain both
    implementations simultaneously, as we bisect to find the performance
    regression that we're currently investigating.
    acdlite committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    a74c51c View commit details
    Browse the repository at this point in the history