Commits on Nov 16, 2020

1. findDOMNode: Remove return pointer mutation …

   The last step of the `findDOMNode` algorithm is a search of the
   current tree.
   
   When descending into a child node, it mutates `child.return` so that it
   points to the current fiber pair, instead of a work-in-progress. This
   can cause bugs if `findDOMNode` is called at the wrong time, like in
   an interleaved event.
   
   For this reason (among others), you're not suppposed to use
   `findDOMNode` in Concurrent Mode. However, we still have some internal
   uses that we haven't migrated.
   
   To reduce the potential for bugs, I've removed the `.return` pointer
   assignment in favor of recursion.

   

   acdlite committed Nov 16, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for 945a6f4
   • Browse repository at this point

   Copy the full SHA

   945a6f4 View commit details

   Browse the repository at this point in the history