Use cache in the fixture #20303
Closed
Use cache in the fixture #20303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
gaearon
commented
Nov 20, 2020
gaearon
commented
Nov 20, 2020
| @@ -10,10 +11,13 @@ function resolve(path) { | |||
| } | |||
|
|
|||
| module.exports = async function(req, res) { | |||
| CacheContext._currentValue = createCache(); | |||
There was a problem hiding this comment.
Essentially a global now. But it should probably be created by the server itself (?)
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 94543c8:
|
gaearon
force-pushed
the
simple-cache
branch
from
3d69372
to
9a29464
Compare
Details of bundled changes.Comparing: 89d4fe1...94543c8 react-test-renderer
react-dom
react-native-renderer
react-transport-dom-relay
react-transport-native-relay
react-art
react-server
react-transport-dom-webpack
react-reconciler
react-debug-tools
ReactDOM: size: 0.0%, gzip: 🔺+0.1% Size changes (experimental) |
Details of bundled changes.Comparing: 89d4fe1...94543c8 react-test-renderer
react-dom
react-native-renderer
react-transport-dom-relay
react-transport-native-relay
react-art
react-server
react-transport-dom-webpack
react-reconciler
react-debug-tools
ReactDOM: size: 🔺+0.2%, gzip: 🔺+0.1% Size changes (stable) |
gaearon
commented
Nov 20, 2020
| for (var key in require.cache) { | ||
| delete require.cache[key]; | ||
| } | ||
| // for (var key in require.cache) { |
Remove the actual implementation so we can fill it in from scratch. We'll be starting with the server one but for now let's make both throw. Also remove the cache entry point in the React package for now. Because it will go through the dispatcher. The fetch test still fails and our fixture does, too. I'll fix them next.
This implements a naive readCache() in the Flight Server environment only. It lets us fix up the NodeFetch test to use Server Components.
|
Cleaned up and resubmitted as #20315 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't yet add necessary APIs. But it hooks the cache up to the fixture. Fetching works.
This adds
readCacheto the dispatcher. Currently it's copy pasta fromreadContextand actually requires passing in the context. This would be fixed later on. For now I just need an injection mechanism that's usable on the client but doesn't throw in the Flight Server environment. It would be replaced by dedicated Hooks that will also let us remove the cache entry point.