Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconcile element types of lazy component yielding the same type #20357

Merged
merged 5 commits into from
Dec 1, 2020
Merged

Reconcile element types of lazy component yielding the same type #20357

merged 5 commits into from
Dec 1, 2020

Commits on Dec 1, 2020

  1. Reconcile element types of lazy component yielding the same type

    @sebmarkbage
    sebmarkbage committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    ffe59a8 View commit details
    Browse the repository at this point in the history

  2. Add some legacy mode and suspense boundary flushing tests

    @sebmarkbage
    sebmarkbage committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    135e5c1 View commit details
    Browse the repository at this point in the history

  3. Fix infinite loop in legacy mode 

    In legacy mode we typically commit the suspending fiber and then rerender
the nearest boundary to render the fallback in a separate commit.

We can't do that when the boundary itself suspends because when we try to
do the second pass, it'll suspend again and infinite loop.

Interestingly the legacy semantics are not needed in this case because
they exist to let an existing partial render fully commit its partial state.

In this case there's no partial state, so we can just render the fallback
immediately instead.
    @sebmarkbage
    sebmarkbage committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    b501246 View commit details
    Browse the repository at this point in the history

  4. Check fast refresh compatibility first 

    resolveLazy can suspend and if it does, it can resuspend. Fast refresh
assumes that we don't resuspend. Instead it relies on updating the inner
component later.
    @sebmarkbage
    sebmarkbage committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    76d4a7d View commit details
    Browse the repository at this point in the history

  5. Use timers instead of act to force fallbacks to show

    @sebmarkbage
    sebmarkbage committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    9fb5014 View commit details
    Browse the repository at this point in the history