Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update package.json versions as part of build step #20579

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Update package.json versions as part of build step #20579

merged 1 commit into from
Jan 13, 2021

Commits on Jan 13, 2021

  1. Update package.json versions as part of build step 

    Fixes issue in the new build workflow where the experimental packages do
not include "experimental" in the version string. This was because the
previous approach relied on the RELEASE_CHANNEL environment variable,
which we are no longer setting in the outer CI job, since we use the
same job to build both channels. To solve, I moved the version
post-processing into the build script itself.

Only affects the new build workflow. Old workflow is unchanged.

Longer term, I would like to remove version numbers from the source
entirely, including the package.jsons. We should use a placeholder
instead; that's mostly how it already works, since the release script
swaps out the versions before we publish to stable.
    @acdlite
    acdlite committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    33ef48f View commit details
    Browse the repository at this point in the history