-
Notifications
You must be signed in to change notification settings - Fork 47.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use toMatchInlineSnapshot for dehydrated values #20618
Use toMatchInlineSnapshot for dehydrated values #20618
Conversation
Comparing: 1214b30...56fcc69 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ad46678:
|
d3b923b
to
ad46678
Compare
ad46678
to
9d8854e
Compare
bb557cd
to
634c8b6
Compare
634c8b6
to
0be6c2f
Compare
Merge conflicts~ |
This reverts commit 9fd6735.
Same reason why jest can fail with "could not find all inline snapshots". Since we don't need "done()" on async tests we can safely remove it.
0be6c2f
to
ee699c0
Compare
@bvaughn Resolved |
packages/react-devtools-shared/src/__tests__/dehydratedValueSerializer.js
Show resolved
Hide resolved
packages/react-devtools-shared/src/__tests__/inspectedElementSerializer.js
Show resolved
Hide resolved
packages/react-devtools-shared/src/__tests__/treeContextStateSerializer.js
Show resolved
Hide resolved
Thanks! |
Summary
There may be other places where we want to use the serializer. I only reverted
9fd6735
(#20548) and tried to fixyarn test-build-devtools
Test Plan