Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't run effects if a render phase update results in unchanged deps #20676

Merged
merged 9 commits into from
Jan 29, 2021
Merged

fix: don't run effects if a render phase update results in unchanged deps #20676

merged 9 commits into from
Jan 29, 2021

Commits on Jan 27, 2021

  1. current behavior of effect dependencies on render phase updates

    @eps1lon
    eps1lon committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    c8435e7 View commit details
    Browse the repository at this point in the history

  2. fix: don't schedule effects when render phase updates aren't committed

    @eps1lon
    eps1lon committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    5bcce83 View commit details
    Browse the repository at this point in the history

  3. apply fix to new fork

    @eps1lon
    eps1lon committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    6cfd74d View commit details
    Browse the repository at this point in the history

  4. Use suggested test name

    @eps1lon
    eps1lon committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    9dfcd56 View commit details
    Browse the repository at this point in the history

  5. devtools: compare effects by deps not referential equality

    @eps1lon
    eps1lon committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    0f58f40 View commit details
    Browse the repository at this point in the history

  6. disable type checking for added functions

    @eps1lon
    eps1lon committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    3cdd353 View commit details
    Browse the repository at this point in the history

  7. bump CircleCI

    @eps1lon
    eps1lon committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    e39a670 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2021

  1. Be more defensive about useState({ deps })

    @eps1lon
    eps1lon committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    77ed727 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2021

  1. bail out early if memoizedState didn't change

    @eps1lon
    eps1lon committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    5c24bb5 View commit details
    Browse the repository at this point in the history