Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Not for merge] Test sizebot #20746

Closed
wants to merge 2 commits into from
Closed

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Feb 5, 2021

The size should go up

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 5, 2021
@sizebot
Copy link

sizebot commented Feb 5, 2021

Size changes

Comparing: eeb1325...26330bb

Stable channel

Details of bundled changes.

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactDOM-profiling.js +71.4% +2.9% 414.6 KB 710.46 KB 76.68 KB 78.89 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% 0.0% 142.85 KB 142.85 KB 36.52 KB 36.52 KB UMD_DEV
react-dom-server.node.development.js 0.0% 0.0% 136.78 KB 136.78 KB 36.32 KB 36.32 KB NODE_DEV
react-dom-server.node.production.min.js 0.0% 0.0% 20.18 KB 20.18 KB 7.58 KB 7.58 KB NODE_PROD
ReactDOMTesting-prod.js 🔺+75.7% 🔺+3.1% 391.05 KB 686.92 KB 73.82 KB 76.1 KB FB_WWW_PROD
react-dom.development.js +17.6% +0.8% 935.06 KB 1.07 MB 205.91 KB 207.54 KB UMD_DEV
react-dom.production.min.js 🔺+110.4% 🔺+3.3% 119.34 KB 251.1 KB 39.25 KB 40.52 KB UMD_PROD
react-dom.profiling.min.js +106.8% +3.3% 123.43 KB 255.2 KB 40.5 KB 41.82 KB UMD_PROFILING
react-dom.development.js +18.5% +0.8% 889.86 KB 1.03 MB 203.21 KB 204.83 KB NODE_DEV
ReactDOMForked-dev.js +28.8% +1.0% 1 MB 1.29 MB 227.39 KB 229.62 KB FB_WWW_DEV
react-dom.production.min.js 🔺+110.3% 🔺+3.3% 119.42 KB 251.18 KB 38.56 KB 39.84 KB NODE_PROD
ReactDOMForked-prod.js 🔺+74.7% 🔺+2.9% 396.17 KB 692.04 KB 73.47 KB 75.61 KB FB_WWW_PROD
react-dom.profiling.min.js +106.5% +3.2% 123.67 KB 255.43 KB 39.8 KB 41.09 KB NODE_PROFILING
ReactDOMForked-profiling.js +71.4% +2.9% 414.61 KB 710.47 KB 76.68 KB 78.89 KB FB_WWW_PROFILING
ReactDOM-dev.js +28.8% +1.0% 1 MB 1.29 MB 227.59 KB 229.81 KB FB_WWW_DEV
ReactDOM-prod.js 🔺+74.7% 🔺+2.9% 396.16 KB 692.03 KB 73.47 KB 75.61 KB FB_WWW_PROD
react-dom-server.browser.development.js 0.0% 0.0% 135.51 KB 135.51 KB 36.06 KB 36.07 KB NODE_DEV
react-dom-server.browser.production.min.js 0.0% 0.0% 19.76 KB 19.76 KB 7.42 KB 7.42 KB NODE_PROD
ReactDOMServer-dev.js 0.0% 0.0% 146.24 KB 146.24 KB 37.49 KB 37.49 KB FB_WWW_DEV
ReactDOMTesting-dev.js +31.0% +0.8% 953.91 KB 1.22 MB 214.1 KB 215.86 KB FB_WWW_DEV

Experimental channel

Details of bundled changes.

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactDOM-profiling.js +73.4% +2.8% 403.17 KB 699.04 KB 74.9 KB 77 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% 0.0% 144.75 KB 144.75 KB 36.78 KB 36.78 KB UMD_DEV
react-dom-server.node.development.js 0.0% 0.0% 138.57 KB 138.57 KB 36.6 KB 36.6 KB NODE_DEV
react-dom-server.browser.production.min.js 0.0% 0.0% 20.4 KB 20.4 KB 7.57 KB 7.57 KB UMD_PROD
react-dom-server.node.production.min.js 0.0% 0.0% 20.73 KB 20.73 KB 7.68 KB 7.68 KB NODE_PROD
ReactDOMTesting-prod.js 🔺+78.3% 🔺+3.0% 377.83 KB 673.7 KB 71.67 KB 73.83 KB FB_WWW_PROD
react-dom.development.js +16.6% +0.6% 987.59 KB 1.12 MB 215.99 KB 217.29 KB UMD_DEV
react-dom.production.min.js 🔺+104.8% 🔺+3.3% 125.68 KB 257.44 KB 41.21 KB 42.57 KB UMD_PROD
react-dom.profiling.min.js +100.3% +3.3% 131.37 KB 263.13 KB 42.91 KB 44.34 KB UMD_PROFILING
react-dom.development.js +17.5% +0.6% 939.89 KB 1.08 MB 213.05 KB 214.26 KB NODE_DEV
ReactDOMForked-dev.js +29.5% +0.9% 1002.16 KB 1.27 MB 222.57 KB 224.57 KB FB_WWW_DEV
react-dom.production.min.js 🔺+104.7% 🔺+3.3% 125.84 KB 257.61 KB 40.54 KB 41.88 KB NODE_PROD
ReactDOMForked-prod.js 🔺+76.9% 🔺+2.8% 384.79 KB 680.66 KB 71.72 KB 73.74 KB FB_WWW_PROD
react-dom.profiling.min.js +100.0% +3.2% 131.71 KB 263.48 KB 42.28 KB 43.64 KB NODE_PROFILING
ReactDOMForked-profiling.js +73.4% +2.8% 403.18 KB 699.05 KB 74.91 KB 77.01 KB FB_WWW_PROFILING
ReactDOM-dev.js +29.5% +0.9% 1002.15 KB 1.27 MB 222.77 KB 224.77 KB FB_WWW_DEV
ReactDOM-prod.js 🔺+76.9% 🔺+2.8% 384.78 KB 680.65 KB 71.71 KB 73.73 KB FB_WWW_PROD
react-dom-server.browser.development.js 0.0% 0.0% 137.3 KB 137.3 KB 36.35 KB 36.35 KB NODE_DEV
react-dom-server.browser.production.min.js 0.0% 0.0% 20.31 KB 20.31 KB 7.52 KB 7.52 KB NODE_PROD
ReactDOMServer-dev.js 0.0% 0.0% 142.21 KB 142.21 KB 36.48 KB 36.48 KB FB_WWW_DEV
ReactDOMServer-prod.js 0.0% 0.0% 46.58 KB 46.58 KB 10.85 KB 10.85 KB FB_WWW_PROD
ReactDOMTesting-dev.js +32.0% +1.1% 925.57 KB 1.19 MB 208.41 KB 210.62 KB FB_WWW_DEV

ReactDOM: size: 0.0%, gzip: 0.0%

Generated by 🚫 dangerJS against 26330bb

The base and head arguments were flipped, so an n% decrease in bundle
size was instead reported as an n% increase.
@acdlite
Copy link
Collaborator

acdlite commented Feb 5, 2021

Ok it's fixed now, but we should really change the output to sort by magnitude, or something like that. Really easy to miss a significant change if it's not to the main bundle.

Screen Shot 2021-02-05 at 5 41 51 PM

@acdlite
Copy link
Collaborator

acdlite commented Feb 5, 2021

Also this part is clearly wrong. Maybe it's grabbing ReactDOMServer accidentally

ReactDOM: size: 0.0%, gzip: 0.0%

I think what I'd do is sort the bundles by magnitude and collapse the ones that are below a certain threshold.

@gaearon gaearon closed this Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants