Reduce some constant duplication #20761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: 77754ae...40b3ae4 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
|
Note I added tests for all of these events in |
rickhanlonii
approved these changes
Feb 8, 2021
koto
pushed a commit
to koto/react
that referenced
this pull request
Jun 15, 2021
* Reduce some constant duplication * Alphabetize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see if this lets us reclaim some of the byte increase from #20760.
The idea is that for an overwhelming majority of events, the DOM name is just the lowercase version of the React name without the
onbefore it. We already do some string acrobatics to get the React name, so why not reuse them and remove the repetition of almost the same term. This was a bit harder to do before because this list was also used for priorities, but it's not anymore. I hardcoded the exceptions.