Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import total lanes from reconciler #20886

Closed

Conversation

rickhanlonii
Copy link
Member

@rickhanlonii rickhanlonii commented Feb 26, 2021

Overview

This PR attempts to re-add the changes from here that were reverted to unblock main.

The test fails because we're importing from the reconciler without mocking/forking the ReactFiberHostConfig.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 26, 2021
@sizebot
Copy link

sizebot commented Feb 26, 2021

Comparing: 2e8bbcb...50813fe

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 122.55 kB 122.55 kB = 39.48 kB 39.48 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 129.13 kB 129.13 kB = 41.53 kB 41.53 kB
facebook-www/ReactDOM-prod.classic.js = 406.12 kB 406.12 kB = 75.38 kB 75.38 kB
facebook-www/ReactDOM-prod.modern.js = 394.47 kB 394.47 kB = 73.49 kB 73.49 kB
facebook-www/ReactDOMForked-prod.classic.js = 406.13 kB 406.13 kB = 75.38 kB 75.38 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 50813fe

@acdlite
Copy link
Collaborator

acdlite commented Feb 26, 2021

Put it in shared? Or hard coding it seems fine, honestly

@bvaughn
Copy link
Contributor

bvaughn commented Feb 26, 2021

I'm not completely against hard-coding but it makes me uneasy. Maybe if we had some static check that CI ran to ensure they were the same 😅

I'm concerned that dev tools get broken too frequently by changes in packages like reconciler. It's too easy for people to forget or overlook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants