Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove my deadname from AUTHORS #21152

Merged
merged 1 commit into from
Mar 31, 2021
Merged

Remove my deadname from AUTHORS #21152

merged 1 commit into from
Mar 31, 2021

Conversation

learosema
Copy link
Contributor

Summary

The AUTHORS contains my name assigned at birth. I prefer to have it removed from the list as I prefer my deadname to not be public. About a year ago, I changed the .mailmap so the git shortlog -se script would generate a list with my correct name; I'd be ok with that. But as the contributions I made to react was only a small documentation fix in the past, it's also ok for me to remove me completely.

@sizebot
Copy link

sizebot commented Mar 31, 2021

Comparing: f8ef4ff...cf20925

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 122.65 kB 122.65 kB = 39.35 kB 39.35 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 129.21 kB 129.21 kB = 41.43 kB 41.43 kB
facebook-www/ReactDOM-prod.classic.js = 405.89 kB 405.89 kB = 75.39 kB 75.39 kB
facebook-www/ReactDOM-prod.modern.js = 394.15 kB 394.15 kB = 73.53 kB 73.52 kB
facebook-www/ReactDOMForked-prod.classic.js = 405.89 kB 405.89 kB = 75.39 kB 75.39 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against cf20925

@gaearon gaearon merged commit 0e96bdd into facebook:master Mar 31, 2021
@gaearon
Copy link
Collaborator

gaearon commented Mar 31, 2021

Sorry about this.

About a year ago, I changed the .mailmap so the git shortlog -se script would generate a list with my correct name

I think you're saying that next time we regenerate the list, it will now use the correct name — is that right? To be honest I don't remember the last time we ran it, I think we might have forgotten to do so during the 17 release.

@learosema learosema deleted the patch-2 branch April 1, 2021 11:15
acdlite pushed a commit to acdlite/react that referenced this pull request Apr 11, 2021
acdlite pushed a commit to acdlite/react that referenced this pull request Apr 13, 2021
acdlite pushed a commit to acdlite/react that referenced this pull request Apr 16, 2021
acdlite pushed a commit to acdlite/react that referenced this pull request Apr 16, 2021
acdlite pushed a commit to acdlite/react that referenced this pull request Apr 19, 2021
koto pushed a commit to koto/react that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants