Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Don't flush discrete updates at end of batchedUpdates, only legacy sync updates #21229

Merged
merged 1 commit into from
Apr 21, 2021

Commits on Apr 21, 2021

  1. Fix: Don't flush discrete at end of batchedUpdates

    The outermost `batchedUpdates` call flushes pending sync updates at the
    end. This was intended for legacy sync mode, but it also happens to
    flush discrete updates in concurrent mode.
    
    Instead, we should only flush sync updates at the end of
    `batchedUpdates` for legacy roots. Discrete sync updates can wait to
    flush in the microtask.
    
    `discreteUpdates` has the same issue, which is how I originally noticed
    this, but I'll change that one in a separate commit since it requires
    updating a few (no longer relevant) internal tests.
    acdlite committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    c8bd181 View commit details
    Browse the repository at this point in the history