-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update supported devEngines #21364
Update supported devEngines #21364
Conversation
CI uses 12.19
The Code Sandbox documentation says: // Node.js version to use for building the PR.
// Supported versions are '10' (10.23.0, default), '12' (12.20.0) and '14' (14.15.1).
"node": "14" And CI is failing with an error message that says:
Which suggests to me that we should update the "node": "14" |
Comparing: 9a25916...c683596 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
Good point. I went with the lowest possible version that's also being used in CI. |
Thanks~ |
Summary
Change
devEngines
to indicate the required node version to perform every development workflow.With
node@12.16.0
yarn build react-server-dom-webpack/node-loader
throws withProbably because of the way
exports
field inpackages/react-server-dom-webpack/package.json
is constructed.With
node@12.17.0
the command passes.Test Plan
yarn build react-server-dom-webpack/node-loader
passes innode@12.17.0
andnode@16.0.0