Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fizz] Allow dangerouslySetInnerHTML in <option> #21373

Merged
merged 1 commit into from
May 4, 2021

Conversation

sebmarkbage
Copy link
Collaborator

I didn't think this was valid because if you don't provide a value for the option, we don't know whether to select it or not. However it's arguably valid if you do provide the value attribute.

We should probably have a warning if you provide dangerouslySetInnerHTML and don't provide a value attribute though. Both server and client.

@facebook-github-bot facebook-github-bot added React Core Team Opened by a member of the React Core Team CLA Signed labels Apr 28, 2021
@sizebot
Copy link

sizebot commented Apr 28, 2021

Comparing: 9a25916...03ad985

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 122.76 kB 122.76 kB = 39.42 kB 39.42 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 129.34 kB 129.34 kB = 41.51 kB 41.51 kB
facebook-www/ReactDOM-prod.classic.js = 406.92 kB 406.92 kB = 75.31 kB 75.31 kB
facebook-www/ReactDOM-prod.modern.js = 394.95 kB 394.95 kB = 73.41 kB 73.41 kB
facebook-www/ReactDOMForked-prod.classic.js = 406.92 kB 406.92 kB = 75.31 kB 75.31 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactDOMServer-prod.modern.js +0.44% 71.74 kB 72.05 kB +0.22% 14.82 kB 14.86 kB

Generated by 🚫 dangerJS against 03ad985

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants