Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevTools refactor Profiler commit tree reconstruction to be iterative #21383

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Apr 28, 2021

Resolves #19839

@sizebot
Copy link

sizebot commented Apr 28, 2021

Comparing: 86f3385...b925a96

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 122.49 kB 122.49 kB = 39.38 kB 39.38 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 129.02 kB 129.02 kB = 41.46 kB 41.46 kB
facebook-www/ReactDOM-prod.classic.js = 406.28 kB 406.28 kB = 75.26 kB 75.26 kB
facebook-www/ReactDOM-prod.modern.js = 394.31 kB 394.31 kB = 73.29 kB 73.29 kB
facebook-www/ReactDOMForked-prod.classic.js = 406.28 kB 406.28 kB = 75.26 kB 75.26 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against b925a96

@bvaughn bvaughn merged commit 3c21aa8 into facebook:master Apr 28, 2021
@bvaughn bvaughn deleted the devtools-profiler-commit-tree-recursion-to-iteration branch April 28, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: "Maximum call stack size exceeded" for getCommitTree
3 participants