Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test fixture for scheduling profiler #21397

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Apr 30, 2021

Related to #21379

Adds a test fixture for the "scheduling profiler" (live at react-scheduling-profiler.vercel.app).

Right now the fixture shows that the experimental OSS release works:
Screen Shot 2021-04-30 at 1 23 12 PM

On an on-demand server though, these marks are being logged:
Screen Shot 2021-04-30 at 2 43 39 PM

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 30, 2021
@sizebot
Copy link

sizebot commented Apr 30, 2021

Comparing: 269dd6e...4842a89

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 122.49 kB 122.49 kB = 39.38 kB 39.38 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 129.02 kB 129.02 kB = 41.46 kB 41.46 kB
facebook-www/ReactDOM-prod.classic.js = 406.89 kB 406.89 kB = 75.31 kB 75.31 kB
facebook-www/ReactDOM-prod.modern.js = 394.75 kB 394.75 kB = 73.34 kB 73.35 kB
facebook-www/ReactDOMForked-prod.classic.js = 406.89 kB 406.89 kB = 75.31 kB 75.31 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 4842a89

@bvaughn bvaughn merged commit b6644fa into facebook:master Apr 30, 2021
@bvaughn bvaughn deleted the add-scheduling-profiler-fixture branch April 30, 2021 19:23
@bvaughn
Copy link
Contributor Author

bvaughn commented Apr 30, 2021

Just a fixture so I'm going to go ahead and merge.

koto pushed a commit to koto/react that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants